Closed Bug 2037663 Opened 6 months ago Closed 5 months ago

Prepare search tests for the SRD pref flip

Categories

(Firefox :: Settings UI, task)

task

Tracking

()

RESOLVED FIXED
153 Branch
Tracking Status
firefox152 --- fixed
firefox153 --- fixed

People

(Reporter: hjones, Assigned: akulyk)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp])

Attachments

(2 external files)

We need to make sure our tests for search features in preferences will pass with the SRD pref enabled or disabled. We need to:

  • create a new browser-srd.toml file for sync tests that duplicates the old /browser/components/preferences/tests/search/browser.toml , but with dupe-manifest=true and the browser.settings-redesign.enabled pref set to true
  • register this manifest in browser/components/preferences/moz.build
  • remove any tests that already set browser.settings-redesign.enabled to true from the old browser.toml file since these don't need to work with the pref disabled
  • clean up any code setting the SRD pref from within the test files (this will be read from the manifest)
  • remove any tests from the new manifest that are only relevant to the old UI
  • fix any failing tests
  • add new tests if there are any obvious gaps

This work may have already been covered by bug 2013057 - we should start by taking a look at what was done there and seeing if we can clean it up so that any irrelevant tests can be removed easily when the old code is no longer needed.

Blocks: 2037820
No longer blocks: srd-tests
Assignee: nobody → mkennedy
Assignee: mkennedy → nobody

My bad, wrong ticket. I meant to add myself to Bug 2037662

Assignee: nobody → akulyk

Hi Anna, I just wanted to flag the fact that significant accessibility work is ongoing for the moz-box-group that allows users to manage their search engines. So we shouldn't remove the old XUL search engine table or tests that touch it until bug 1965590 is fixed.

Flags: needinfo?(akulyk)
See Also: → 1965590

Thanks Stephanie! We are not removing any legacy tests as the part of this bug. We just making sure that the tests will pass with the SRD pref both enabled or disabled.

Flags: needinfo?(akulyk)
Attachment #9588095 - Attachment description: WIP: Bug 2037663 - Prepare search tests for the SRD pref flip r=#recomp-reviewers → Bug 2037663 - Prepare search tests for the SRD pref flip r=#recomp-reviewers
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Attachment #9590370 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: This is to ensure that the settings testing is also run on the Beta branch.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing: This patch is for running the Search settings and Search results tests without the SRD prefs, there are no user-facing changes.
  • Risk associated with taking this patch: low
  • Explanation of risk level: Just a code re-organization patch.
  • String changes made/needed?: No string changes
  • Is Android affected?: no
Flags: in-testsuite+
Attachment #9590370 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: