Prepare search tests for the SRD pref flip
Categories
(Firefox :: Settings UI, task)
Tracking
()
People
(Reporter: hjones, Assigned: akulyk)
References
(Blocks 1 open bug)
Details
(Whiteboard: [recomp])
Attachments
(2 external files)
We need to make sure our tests for search features in preferences will pass with the SRD pref enabled or disabled. We need to:
- create a new
browser-srd.tomlfile for sync tests that duplicates the old/browser/components/preferences/tests/search/browser.toml, but withdupe-manifest=trueand thebrowser.settings-redesign.enabledpref set totrue - register this manifest in
browser/components/preferences/moz.build - remove any tests that already set
browser.settings-redesign.enabledtotruefrom the oldbrowser.tomlfile since these don't need to work with the pref disabled - clean up any code setting the SRD pref from within the test files (this will be read from the manifest)
- remove any tests from the new manifest that are only relevant to the old UI
- fix any failing tests
- add new tests if there are any obvious gaps
This work may have already been covered by bug 2013057 - we should start by taking a look at what was done there and seeing if we can clean it up so that any irrelevant tests can be removed easily when the old code is no longer needed.
Updated•6 months ago
|
| Reporter | ||
Updated•6 months ago
|
Updated•6 months ago
|
Updated•6 months ago
|
Comment 1•6 months ago
|
||
My bad, wrong ticket. I meant to add myself to Bug 2037662
Comment 3•6 months ago
|
||
Hi Anna, I just wanted to flag the fact that significant accessibility work is ongoing for the moz-box-group that allows users to manage their search engines. So we shouldn't remove the old XUL search engine table or tests that touch it until bug 1965590 is fixed.
Thanks Stephanie! We are not removing any legacy tests as the part of this bug. We just making sure that the tests will pass with the SRD pref both enabled or disabled.
Updated•6 months ago
|
Comment 6•5 months ago
|
||
| bugherder | ||
Original Revision: https://phabricator.services.mozilla.com/D301560
Updated•5 months ago
|
Comment 8•5 months ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined/Reason for urgency: This is to ensure that the settings testing is also run on the Beta branch.
- Code covered by automated testing?: yes
- Fix verified in Nightly?: yes
- Needs manual QE testing?: no
- Steps to reproduce for manual QE testing: This patch is for running the Search settings and Search results tests without the SRD prefs, there are no user-facing changes.
- Risk associated with taking this patch: low
- Explanation of risk level: Just a code re-organization patch.
- String changes made/needed?: No string changes
- Is Android affected?: no
Updated•5 months ago
|
Updated•5 months ago
|
Updated•5 months ago
|
Description
•