2037698 - Netflix video is magenta and white when using WebRender (Software D3D11)

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: screenshot.png

[Tracking Requested - why for this release]:

@ Jeff: I suspect this bug is a regression from your fix for HDR bug 2025015 in Fx151. I bisected to this regression range, but I couldn't bisect further because Netflix started returning seemingly unrelated errors:

https://hg-edge.mozilla.org/mozilla-central/pushloghtml?fromchange=1f2552c4d19da76efc011a18219ce004d3d89e5c&tochange=b431043d8af26374a363e9489091e112dc32986c

Steps to reproduce

1. ⚠️ Note that you may need to set pref media.eme.video.prefer-platform-decoder to false to work around Netflix bug 2037550 in Fx152. However, this SW-WR bug predates that bug.
2. Enable SW-WR pref gfx.webrender.software = true and restart Firefox. I'm testing on Windows 11.
3. Log into netflix.com and play a video.

Expected result

Video playback should use normal colors. :)

Actual result

The website looks fine, but video playback is magenta and white. See the attached screenshot.

See also similar bug 1975517 about magenta and white video on tv.apple.com when using SW-WR.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Sotaro, can you take a look?

Comment 2

[Sotaro Ikeda [:sotaro]]

The problem happened with WebRender (Software D3D11). The problem did not happen with WebRender (Software).

Comment 3

[Sotaro Ikeda [:sotaro]]

I confirmed the problem with the following Youtube video with WebRender (Software D3D11) and HDR enabled.
https://www.youtube.com/watch?v=LXb3EKWsInQ

Comment 4

[Sotaro Ikeda [:sotaro]]

CompositorD3D11 does not support HDR ID3D11Texture2D video rendering. It seems to cause the problem. It seems better to disable hardware video decoding with WebRender (Software D3D11) and disable software decoded video uploading to ID3D11Texture2D. It makes the problem simple.

hardware video decoding is necessary for the followings. WebRender (software-based D3D11) does not support either of these features.

• zero video frame copy
• video overlay

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 2037698 - Disable hardware video decoding with WebRender (Software D3D11)

Comment 6

[Sotaro Ikeda [:sotaro]]

It seemed that setting mPSConstants.vCoefficient[0] in CompositorD3D11::DrawQuad() seemed to cause the problem.

When mPSConstants.vCoefficient[0] was set to 1, video was rendered as non magenta, though clolor was a bit darker than video overlay.

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 2037698 - Fix RescalingFactorForColorDepth()

Comment 8

[Donal Meehan [:dmeehan]]

:sotaro, could you add a beta uplift request when you land this? Hopefully, it will land later today?
Tomorrow is the last day of uplifts for Fx151, I'll wait until it's in nightly before uplifting.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2bbd7be91826
https://hg.mozilla.org/integration/autoland/rev/416dfcaa3632
Fix RescalingFactorForColorDepth() r=gfx-reviewers,jrmuizel

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/416dfcaa3632

Comment 11

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 2037698 - Fix RescalingFactorForColorDepth()

10 and 12 bits color depth image are using 16 bits integers for storage.
Data is placed as MSB and texture is sampled within [0 - 1] range.

Original Revision: https://phabricator.services.mozilla.com/D299304

Comment 12

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: HDR video rendering was broken with WebRender (Software D3D11).
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: The fix change only one parameter for HDR video rendering with WebRender (Software D3D11).
• String changes made/needed?: No
• Is Android affected?: no

Comment 13

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/4b15e13d3dfc
https://hg.mozilla.org/releases/mozilla-beta/rev/23923c1ac766

Comment 14

[Chris Peterson [:cpeterson]]

Verified fixed in Nightly 152.0a1 (2026-05-12)