Open Bug 2037847 Opened 6 months ago Updated 5 months ago

Missing `chrome://browser/skin/preferences/alwaysAsk.png` icon for `mailto` content type in about:preferences

Categories

(Firefox :: Settings UI, defect)

Firefox 140
Desktop
All
defect

Tracking

()

UNCONFIRMED

People

(Reporter: aoia7rz7l, Unassigned, NeedInfo)

References

(Regression)

Details

(Keywords: regression)

Tested on 140.10.1esr and Nightly 152.0a1(2026-05-06) BuildID 20260506210744.

STR:

Open about:preferences#general > Files and Applications > Applications.

Expected Behavior:

chrome://browser/skin/preferences/alwaysAsk.png is used as the icon for mailto content type.

Actual Behavior:

Missing icon for mailto content type. Meanwhile the Always Ask action type continues to use chrome://browser/skin/preferences/alwaysAsk.png as its icon.

Mozregression returned

Last good revision: 055c31fc47459aecf331be04940f65833993a0d2
First bad revision: d122340fa854968184984314193229d8cbf6e02c
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=055c31fc47459aecf331be04940f65833993a0d2&tochange=d122340fa854968184984314193229d8cbf6e02c

This probably also affects other "stubEntry": true content types in handlers.json like irc or ircs but I think those were removed from existing profiles in bug 1955497.

See Also: → 2035999

The Bugbug bot thinks this bug should belong to the 'Toolkit::Startup and Profile System' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Startup and Profile System
Product: Firefox → Toolkit
Component: Startup and Profile System → File Handling
Product: Toolkit → Firefox

Setting Regressed by field after analyzing regression range found by mozregression in comment #0.

Keywords: regression
Regressed by: 1964046

Just to clarify a bit because I'm a little lost between the summary and the description of this bug... I don't see an icon for mailto in 139 on macOS, either. I'm also confused on how there would have been an icon before, from code inspection of https://hg-edge.mozilla.org/integration/autoland/rev/d122340fa854968184984314193229d8cbf6e02c which is indicated as the regressor in comment 0. What icon was there before? A moz-icon reference to an OS protocol icon, or something?

The bug summary also kind of implies that alwaysAsk.png is missing, but it's present for me. So on the whole a bit lost on what this is reporting and what actually regressed at what point. Could you help us out by clarifying a bit? Thank you!

Flags: needinfo?(aoia7rz7l)
Keywords: regression
No longer regressed by: 1964046

(In reply to :Gijs (he/him) from comment #3)

What icon was there before?

https://searchfox.org/firefox-esr128/search?q=chrome%3A%2F%2Fbrowser%2Fskin%2Fpreferences%2FalwaysAsk.png&path=&case=false&regexp=false

The bug summary also kind of implies that alwaysAsk.png is missing, but it's present for me.

It is still present for the Always Ask action, but it was also used as the icon for irc/ircs/mailto content-types.

what actually regressed at what point

Could it possibly be https://hg-edge.mozilla.org/integration/autoland/rev/31752f9a1e791446764579f84f4845e38318dd7a (the next commit)?

Admittedly I did have to juggle with mozregression for a bit because it had problem switching from taskcluster to autoland (with the following error message):

INFO: Last good revision: 907a3d528f5eef73b26914c19fac7c0b0d79e190
INFO: First bad revision: 80cc20e2740dfb72182d95e0ca08ab925fbba341
INFO: Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=907a3d528f5eef73b26914c19fac7c0b0d79e190&tochange=80cc20e2740dfb72182d95e0ca08ab925fbba341

INFO: ************* Switching to autoland by process of elimination (no branch detected in commit message)
ERROR: Unable to exploit the merge commit. Origin branch is mozilla-central, and the commit message for 80cc20e2 was:
Revert "Bug 1965343 - Adopt whole tab group at once in replaceGroupWithWindow r=tabbrowser-reviewers,sthompson" for causing bc failures @browser_tab_groups.js.

This reverts commit fac3f86e95e69ae1651ce1012aa28edcf80bc83d.
Flags: needinfo?(aoia7rz7l)

I got pretty confused because I just tried again with 128 and still couldn't reproduce the "good" state of showing this icon. I eventually realized that I only see the "always ask" icon if "always ask" is actually selected as the action. For any other situation (OS app, gmail, whatever), I don't see an icon.

Consistently not showing an icon actually seems better than showing "always ask", as it's being shown next to the filetype/protocol while it isn't really a "mailto" icon (though it would be best to show a meaningful icon for the protocol).

Hanna, are there any plans for the iconography as part of the settings redesign?

Component: File Handling → Settings UI
Flags: needinfo?(hjones)

(In reply to :Gijs (he/him) from comment #5)

Consistently not showing an icon actually seems better than showing "always ask", as it's being shown next to the filetype/protocol while it isn't really a "mailto" icon (though it would be best to show a meaningful icon for the protocol).

FWIW I did a quick check and it would appear that Firefox used moz-icon://goat?size=16 as the generic icon up until 61:

Last good revision: 96a6ea5ea3468b4c9e20ff8d9795a7ef136213a9 (2018-05-22)
First bad revision: 47e81ea1ef10189ef210867934bf36e14cf223dc (2018-05-23)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=96a6ea5ea3468b4c9e20ff8d9795a7ef136213a9&tochange=47e81ea1ef10189ef210867934bf36e14cf223dc
...
There are no build artifacts for these changesets (they are probably too old).

possibly https://hg-edge.mozilla.org/mozilla-central/rev/4106f2f28462b5d46aebb8029cd47a64e000a14c (bug 1459556).

I eventually realized that I only see the "always ask" icon if "always ask" is actually selected as the action. For any other situation (OS app, gmail, whatever), I don't see an icon.

This seems to be a separate issue that was introduced at some point in 64:

Last good revision: 2a59b432d2bd9b15ceec6b9435f60c785a820ef2 (2018-09-12)
First bad revision: e923330d5bd3aef1f687eddf96a06ad5ec3860ed (2018-09-13)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2a59b432d2bd9b15ceec6b9435f60c785a820ef2&tochange=e923330d5bd3aef1f687eddf96a06ad5ec3860ed
...
There are no build artifacts for these changesets (they are probably too old).

most likely https://hg-edge.mozilla.org/mozilla-central/rev/dcdd547ff76700c4a8aeaee00d645c3a9d3c893a (bug 1488908).

(In reply to :Gijs (he/him) from bug 1488908 comment #7)

I, for one, am excited to find out what bugs we're going to unearth by fixing this one...

Well there we go...

Keywords: regression
Regressed by: 1966357
You need to log in before you can comment on or make changes to this bug.