Open
Bug 2038180
Opened 12 days ago
Updated 11 days ago
Ship keyboard lock intervention to websites that only support navigator.keyboard.lock
Categories
(Web Compatibility :: Interventions, enhancement)
Web Compatibility
Interventions
Tracking
(Not tracked)
NEW
People
(Reporter: saschanaz, Assigned: saschanaz)
References
(Blocks 1 open bug)
Details
(Keywords: leave-open, webcompat:sitepatch-applied)
Attachments
(2 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
No description provided.
| Assignee | ||
Comment 1•12 days ago
|
||
Updated•12 days ago
|
Attachment #9584558 -
Attachment description: WIP: Bug 2038180 - Shim navigator.keyboard.lock → Bug 2038180 - Shim navigator.keyboard.lock r=#webcompat-reviewers
Comment 2•11 days ago
|
||
Updated•11 days ago
|
Attachment #9584644 -
Flags: approval-mozilla-beta?
Comment 3•11 days ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined/Reason for urgency: Games on nVidia's GeForceNow service will not lock the keyboard, leading to a sub-optimal experience.
- Code covered by automated testing?: no
- Fix verified in Nightly?: no
- Needs manual QE testing?: yes
- Steps to reproduce for manual QE testing: Start playing a game on https://play.geforcenow.com/ in fullscreen, and confirm that the keyboard is locked
- Risk associated with taking this patch: low
- Explanation of risk level: This only affects the related nVidia sites, and can't really make the UX any worse.
- String changes made/needed?: none
- Is Android affected?: yes
Flags: qe-verify+
Pushed by twisniewski@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/511e8a3bfeb6
https://hg.mozilla.org/integration/autoland/rev/bcc2d03734fb
Shim navigator.keyboard.lock r=webcompat-reviewers,twisniewski
Updated•11 days ago
|
Keywords: leave-open
Comment 5•11 days ago
|
||
| bugherder | ||
Updated•11 days ago
|
Keywords: webcompat:sitepatch-applied
Updated•11 days ago
|
Attachment #9584644 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in
before you can comment on or make changes to this bug.
Description
•