Closed
Bug 2039455
Opened 3 months ago
Closed 3 months ago
Selected tab missing shadow with Nova theme disabled after bug 2023692
Categories
(Firefox :: Tabbed Browser: Tab Groups, defect)
Tracking
()
RESOLVED
FIXED
152 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr140 | --- | unaffected |
| firefox150 | --- | unaffected |
| firefox151 | --- | unaffected |
| firefox152 | --- | fixed |
People
(Reporter: sam, Assigned: sam)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
After bug 2023692, --tab-selected-shadow is only set when browser.nova.enabled is true, so the selected tab has no shadow in the default configuration.
|
Assignee | |
Comment 1•3 months ago
|
||
After bug 2023692, --tab-selected-shadow is only set when browser.nova.enabled is true, so the selected tab has no shadow in the default configuration. It's not clear why this change was made, but reverting this specific change fixes the Proton theme while also not breaking Nova.
|
||
Updated•3 months ago
|
Assignee: nobody → sam
Status: NEW → ASSIGNED
|
||
Comment 2•3 months ago
|
||
Set release status flags based on info from the regressing bug 2023692
status-firefox150:
--- → unaffected
status-firefox151:
--- → unaffected
status-firefox-esr140:
--- → unaffected
Pushed by mstriemer@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/683d8258827e
https://hg.mozilla.org/integration/autoland/rev/07668cebf9bd
Fix selected tab shadow without Nova. r=desktop-theme-reviewers,tabbrowser-reviewers,nsharpley,mstriemer
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
|
||
Updated•3 months ago
|
QA Whiteboard: [qa-triage-done-c153/b152]
You need to log in
before you can comment on or make changes to this bug.
Description
•