2023692 - Nova tab group label styles in tab strip

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser: Tab Groups, task)

Description

[Stephen Thompson [:sthompson]]

UX spec: https://www.figma.com/design/XT0eDYh4RtbMNWaYQi0efM/Chrome-Sidebar-UX-Specifications--Sprint-1-?node-id=9044-83609&t=8JmJB8LIHAYiDTm9-0

• Tab group labels have a different shape and no border
• Use new group color tokens from bug 2023691 as needed
• Overflow counter for collapsed-group-with-active-tab is restyled
• Vertical tab strip size and placement of tab group label and tab group line has different rules than before

Other details to review:

• tab group line size/spacing within the tab strip
• tab-tab spacing, tab-group spacing, group-tab spacing, etc. should follow spec
• keyboard focus ring when group label is keyboard-selected
• color effects when dragging tabs to create a tab group or drop a tab into a collapsed tab group

Comment 1

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 2023692 - Nova tab group label styles in tab strip r=sthompson

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/47487b408d72
https://hg.mozilla.org/integration/autoland/rev/5396b289b29f
Nova tab group label styles in tab strip r=sthompson,desktop-theme-reviewers,tabbrowser-reviewers,mstriemer,urlbar-reviewers,adw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9dde18b6b228
https://hg.mozilla.org/integration/autoland/rev/92a9f1b3c6ce
Revert "Bug 2023692 - Nova tab group label styles in tab strip r=sthompson,desktop-theme-reviewers,tabbrowser-reviewers,mstriemer,urlbar-reviewers,adw" for causing stylelint failures

Comment 4

[Silaghi Andreea]

Backed out for causing stylelint failures
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/themes/shared/tabbrowser/tabs.css:10:3 | Unexpected duplicate "--tab-min-height" (declaration-block-no-duplicate-custom-properties)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e5c2b2c0903b
https://hg.mozilla.org/integration/autoland/rev/605e035158a7
Nova tab group label styles in tab strip r=sthompson,desktop-theme-reviewers,tabbrowser-reviewers,mstriemer,urlbar-reviewers,adw

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/605e035158a7

Comment 7

[Florin Bilt]

(In reply to Norisz Fay [:noriszfay] from comment #6)

https://hg.mozilla.org/mozilla-central/rev/605e035158a7

Perfherder has detected a talos performance change from push 605e035158a7a9e3e25924a84abd23b898d84f10.

No action is required from the author; this comment is provided for informational purposes only.

Improvement	Test	Platform	Options	Absolute values [old vs new]
5%	tresize (doc)	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	20.71 ms -> 19.66 ms

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.