Closed Bug 2039854 Opened 3 months ago Closed 1 month ago

Container tab line exceeds horizontal tab in Nova with pref enabled

Categories

(Firefox :: Tabbed Browser, defect, P3)

Firefox 152
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox153 --- disabled

People

(Reporter: mercichao, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-nova])

Attachments

(4 files)

Attached image Region.png

While bug #2026252 fixed the issue of the container line going out of bounds in Nova, it introduced a “new” design that looks awkward and inconsistent. Wouldn’t it be better to keep the line contained within the tab for a cleaner appearance?

.tabbrowser-tab[usercontextid] > .tab-stack > .tab-background > .tab-context-line {
  position: absolute;
  top: var(--tab-block-margin);
  margin: 0;
  width: calc( 100% - var(--tab-min-height) + 6px );
  align-self: center;
}
Keywords: regression
Regressed by: 2026252
Blocks: nova-chrome
Summary: Container tab line exceeds tab → Container tab line exceeds tab in Nova

:nsharpley, since you are the author of the regressor, bug 2026252, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(nsharpley)

Yes, I think that would look nicer. We have bug 2035553 coming up to optionally make the UI more compact -- I think we can do another pass on this when we have a better idea of what the width calculation would need to be. I'm not sure that a hardcoded 6px will look consistent on all platforms and UI density.

Type: enhancement → defect
Flags: needinfo?(nsharpley)
Priority: -- → P3
No longer regressed by: 2026252
See Also: → 2026252
Summary: Container tab line exceeds tab in Nova → Container tab line exceeds horizontal tab in Nova
Whiteboard: [fidefe-nova]
Attached image Region.png

(In reply to Stephen Thompson [:sthompson] from comment #2)

I'm not sure that a hardcoded 6px will look consistent on all platforms and UI density.

Theoretically, width: calc(100% - var(--tab-min-height)) is the correct answer. However, in practice, the line does not visually cover the whole straight part of the outline. Using 6px in the sample above is somewhat arbitrary, and perhaps 4px or less would be a better choice.

Severity: -- → S4
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Container tab line exceeds horizontal tab in Nova → Container tab line exceeds horizontal tab in Nova with pref enabled

This bug has been marked as a regression. Setting status flag for Nightly to affected.

Note: we may support adjustable tab border-radius around the 155 or 156 releases. If we do that, then a CSS rule based only on tab height would not be sufficient. Let's try to solve for every combo of normal/compact/touch density + round/smooth/sharp border-radius variations.

There is also some discussion about changing the container tab styling to a full colored border around the tab, but at this moment I'm not sure which release that might be targeting.

Attached image Region.png

Need to take a look on split views. 153.0a1 (2026-06-12)

Hi Baku, wondering if this might be a dupe of some of your styling changes?

Flags: needinfo?(amarchesini)

correct. this is should be fixed in the latest nightly + there is a patch in review.

Flags: needinfo?(amarchesini)
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → WORKSFORME
Attached image Region.png

I'm confused with the change in 155. The container line has become hard to recognize and is still cut off in split view, but this time it's covered by the site icon in compact mode.

In fact, simply adding overflow: visible on the tabs in split views will make the line fully visible, although I'm not sure what side effects it might have.

See Also: → 2057172
See Also: 20571722058198
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: