2040934 - landoscript does not log the response body on HTTP errors

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Johan Lorenzo [:jlorenzo]]

While working on bug 2025695, I stumbled upon these logs:

2026-05-20 11:15:35,809 - landoscript.lando - INFO - {'action': 'create-commit', 'commitmsg': 'Automatic version bump NO BUG a=release CLOSED TREE DONTBUILD', 'diff': '<omitted for brevity>', 'date': '2026-05-20T11:15:35.807138+00:00', 'author': 'Release Engineering Landoscript <[e-mail]>'}
2026-05-20 11:15:35,809 - landoscript.lando - INFO - submitting POST request to https://stage.lando.nonprod.webservices.mozgcp.net/api/repo/staging-firefox-main
2026-05-20 11:15:36,658 - scriptworker.utils - DEBUG - retry_async: post: sleeping 12.181867087756187 seconds before retry
2026-05-20 11:15:49,559 - scriptworker.utils - DEBUG - retry_async: post: sleeping 22.660982521419918 seconds before retry
Traceback (most recent call last):
  File "/app/.venv/lib/python3.11/site-packages/scriptworker/utils.py", line 277, in retry_async
    return await func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/.venv/lib/python3.11/site-packages/aiohttp/client.py", line 917, in _request
    resp.raise_for_status()
  File "/app/.venv/lib/python3.11/site-packages/aiohttp/client_reqrep.py", line 636, in raise_for_status
    raise ClientResponseError(
aiohttp.client_exceptions.ClientResponseError: 403, message='Forbidden', url='https://stage.lando.nonprod.webservices.mozgcp.net/api/repo/staging-firefox-main'

It was hard for me to understand what caused the 403 error. Lando outputs the reason in the HTTP response body. Let's display it in the logs.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-releng/scriptworker-scripts] fix(landoscript): log HTTP error response body before raising (bug 2040934) (#1447)

Comment 2

[Johan Lorenzo [:jlorenzo]]

Landed. It'll be in the next deployment.