Closed Bug 2025695 Opened 3 months ago Closed 1 month ago

Add a landoscript task to bump the newtab manifest.json minor version after each XPI release

Categories

(Release Engineering :: Release Automation, task)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rhamoui, Assigned: jlorenzo)

References

Details

Attachments

(11 files)

64 bytes, text/x-github-pull-request
Details | Review
54 bytes, text/x-github-pull-request
Details | Review
56 bytes, text/x-github-pull-request
Details | Review
56 bytes, text/x-github-pull-request
Details | Review
54 bytes, text/x-github-pull-request
Details | Review
60 bytes, text/x-github-pull-request
Details | Review
60 bytes, text/x-github-pull-request
Details | Review
60 bytes, text/x-github-pull-request
Details | Review
59 bytes, text/x-github-pull-request
Details | Review
54 bytes, text/x-github-pull-request
Details | Review
54 bytes, text/x-github-pull-request
Details | Review

As part of the New Tab trainhop process, we need to automate bumping the minor version number in browser/extensions/newtab/manifest.json after each signed XPI release.

Background: The New Tab extension uses a versioning scheme that tracks Firefox's major version (e.g., 150.0, 150.1, 150.2) and resets to the new major on each Firefox release. Currently, bumping the minor version is a manual step in the trainhop process documented here: https://mozilla-hub.atlassian.net/wiki/spaces/FPS/pages/1785135275/Performing+a+train-hop#%5BinlineExtension%5DBumping-the-minor-version-number

Proposed approach (based on discussion with ahal):

  • Add a post-release treescript task to the newtab XPI release graph
  • This task runs as the last step after a signed XPI is built
  • It bumps the minor version in browser/extensions/newtab/manifest.json and lands the change directly in central
  • No manual trigger or Pulse integration needed — the version in-tree will always be one ahead of the latest release

Example: After releasing 150.1, the task automatically bumps the file to 150.2.

Flags: needinfo?(jlorenzo)
Flags: needinfo?(ahal)

I probably said treescript, but I think this is in landoscript these days... but same idea.

To complete this bug we'll want to create a new kind similar to:
https://searchfox.org/firefox-main/source/taskcluster/kinds/release-version-bump/kind.yml

We'll need to ensure the task only runs as part of the newtab addon ship graphs that get triggered by shipit.

We'll also need to update this list and re-deploy landoscript:
https://github.com/mozilla-releng/scriptworker-scripts/blob/e19949e25f0bbc95b9601e8e174bad63dd75d3d3/landoscript/src/landoscript/actions/version_bump.py#L21

There may be other changes needed in landoscript, I'm not sure.

I'll leave the needinfo on jlorenzo up to help find an owner. If we're unable to prioritize atm and someone from newtab wants to take a crack at this, I'm happy to help mentor.

Flags: needinfo?(ahal)
Summary: Add a treescript task to bump the newtab manifest.json minor version after each XPI release → Add a landoscript task to bump the newtab manifest.json minor version after each XPI release

Hey there! I'm taking it. Reem, is there any hard deadline to meet?

Flags: needinfo?(jlorenzo) → needinfo?(rhamoui)
Assignee: nobody → jlorenzo

Thanks Johan! No hard deadline, but would be great to have whenever :)

Flags: needinfo?(rhamoui)

Thanks for looking at this jlorenzo! One thing I'll note is that it looks like the script bumps the patch number of the version, but we're hoping that this script will bump the minor version number.

So 150.0.0 would become 150.1.0. Is that possible?

Flags: needinfo?(jlorenzo)

Authored by https://github.com/JohanLorenzo
https://github.com/mozilla-releng/fxci-config/commit/443bee29794129a9f9a2631b346109be7877b40b
[main] xpi-manifest: add lando support for extension_manifest_version_bump (bug 2025695)

Status: NEW → RESOLVED
Closed: 3 months ago
Flags: qe-verify+
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Flags: needinfo?(jlorenzo)
Keywords: leave-open
Resolution: FIXED → ---

(In reply to Mike Conley (:mconley) (:⚙️) from comment #7)

Thanks for looking at this jlorenzo! One thing I'll note is that it looks like the script bumps the patch number of the version, but we're hoping that this script will bump the minor version number.

So 150.0.0 would become 150.1.0. Is that possible?

Oops! Thanks for catching that. Fixed:

cc'ing the webcompat eng folk so that they're aware this is being worked on, in case they're also interested in auto-bumping their minor version number as well.

Yes! We are interested! Thanks!

Depends on: 2040893
Depends on: 2040934

The last piece landed! The next releases of newtab and webcompat are going to automatically bump the version number. I'm marking this bug as fixed but don't hesitate to reopen it if there's anything I missed 🙂

Status: REOPENED → RESOLVED
Closed: 3 months ago1 month ago
Resolution: --- → FIXED
Duplicate of this bug: 2017974
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: