2041030 - Update the order of sidebar tools

Status: RESOLVED FIXED

(Firefox :: Sidebar, enhancement, P2)

Description

[Ania]

New users:
Order in the sidebar should be the same as the order in the Sidebar settings:

• Open tabs
• Bookmarks
• AI Chatbot
• History
• Tabs from other devices
• Passwords (off by default)

Existing users:
The order should be updated only for the Sidebar settings

• Open tabs
• Bookmarks
• AI Chatbot
• History
• Tabs from other devices
• Passwords (off by default)

Tools order display in the expanded vertical tabs
Left to right: Open tabs, Bookmarks, AI Chatbot, History, Tabs from other devices, Settings. Settings should always be on the utmost right, rather than utmost left as they are now.

Tools order display in the colllapsed vertical tabs
Top to bottom:

• Open tabs
• Bookmarks
• AI Chatbot
• History
• Tabs from other devices
• Setting (should always be at the bottom)

Comment 1

[Stephen Thompson [:sthompson]]

Setting P2 based on Ania's prioritization of related bug 2050756

Comment 3

[Jeremy Swinarton]

Attachment: WIP: Bug 2041030: Update the order of sidebar tools

Comment 4

[Jeremy Swinarton]

The requirements on this bug have changed slightly after some internal discussion.

The original rationale to distinguish between new and existing users was because we thought that the order of the tools in the launcher can be changed by the user (by checking and unchecking items in a certain order in the Customize Sidebar panel), and we wanted these customizations to persist while changing the default order. However, as reported in bug1915440, these reorderings don't actually persist across restarts (or even across windows).

Given this, we decided to reduce the scope of this fix to the following things:

1. Fix the issues with the settings button in the launcher — it should always appear on the far-right or bottom, and when the overflow menu is enabled, it appears at the bottom of the overflow menu. (Right now it can jump around depending on whether the sidebar is expanded or collapsed or if the overflow menu is present.)
2. Change the default order of the other tools to be: Open tabs, Bookmarks, AI Chatbot, History, Tabs from other devices.

We also want to explore what it would take to make the reordering actually persist, and provide a better UI for it (possibly a drag-and-drop interface), but this is a larger project and is better done as part of bug1915440.

Comment 5

[Jeremy Swinarton]

Attachment: Bug 2041030: Part 1 - Update the default order of the sidebar tools r?#tabbrowser-reviewers

Comment 6

[Jeremy Swinarton]

Attachment: Bug 2041030: Part 2 - Always place the sidebar Customize button last r?#tabbrowser-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6ac646d2bb39
https://hg.mozilla.org/integration/autoland/rev/f97398fd139b
Part 1 - Update the default order of the sidebar tools r=tabbrowser-reviewers,sidebar-reviewers,sclements
https://github.com/mozilla-firefox/firefox/commit/6340f9802b20
https://hg.mozilla.org/integration/autoland/rev/44e3576384cc
Part 2 - Always place the sidebar Customize button last r=tabbrowser-reviewers,sidebar-reviewers,sclements

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f97398fd139b
https://hg.mozilla.org/mozilla-central/rev/44e3576384cc