2041077 - mange cookies and site data empty

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[zlice]

Attachment: cache.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:153.0) Gecko/20100101 Firefox/153.0

Steps to reproduce:

try to clear specific site cookies

Actual results:

nothing is listed (see attachment)

Expected results:

search through sites and clear specific caches.

i haven't used this in a while so i have no clue when this changed. i was still able to go to a site, click the shield-check next to the urlbar and clear cookies that way.

also i have firefox remove site cookies on close and a list of sites to keep.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Networking: Cookies' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Kershaw Chang [:kershaw]]

This is the regression range:
https://hg-edge.mozilla.org/mozilla-central/pushloghtml?fromchange=5d85334c95eda979785d121004aa4a8ee310deb4&tochange=cdabc42428fa68fd62d2c05537373e8ae409a194

I think this is likely caused by bug 2034243.
Emma, could you take a look? Thanks.

Comment 3

[Emma Zühlcke [:emz]]

Attachment: Bug 2041077 - Trigger SiteDataManager.updateSites on paneSearchResults too. r?mstriemer

The previous fix for bug 2034243 moved updateSites() into a one-shot paneshown
listener gated on category === "panePrivacy". When the user reaches the privacy
pane's settings via the search-results pane, gotoPref dispatches paneshown for
paneSearchResults, not panePrivacy, so updateSites never runs and the "Manage
Cookies and Site Data" dialog opens with an empty list.

Call updateSites directly at module load instead. The module is imported by
setting-pane.init() (redesign) or by the eager import in privacy.js (legacy),
so this fires exactly once per prefs document regardless of how the privacy
settings are surfaced.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/466d7cc2d506
https://hg.mozilla.org/integration/autoland/rev/d61571b973c6
Trigger SiteDataManager.updateSites on paneSearchResults too. r=mstriemer

Comment 5

[rperta]

https://hg.mozilla.org/mozilla-central/rev/d61571b973c6