2041086 - Address remaining "yellow" Typed OM reification properties

Status: ASSIGNED

(Core :: CSS Parsing and Computation, task)

Description

[Jan Varga [:janv]]

Based on the tracking in bug 2028088 (which tracks the current CSS Typed OM WPT status in Firefox), the main remaining "yellow" properties (passes-half class on wpt.fyi) in css/css-typed-om/the-stylepropertymap/properties/ are currently:

• cursor
• display

This bug tracks additional reification work for these properties.

This bug intentionally excludes:

• fill / stroke (currently only partially supported in Chromium as well)
• vertical-align (currently represented as a shorthand after bug 1830771)

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 2041086 - Enable reification for GenericCursor; r=emilio

cursor values can now be reified into Typed OM values.

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 2041086 - Enable reification for Display; r=emilio

display values can now be reified into Typed OM values.

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 2041086 - Add testing for additional display keyword combinations; r=emilio

Add testing for additional display keyword combinations that are supported by
the current CSS specification but reify as unsupported valued in Typed OM.

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 2041086 - Update vertical-align WPT for shorthand behavior; r=emilio

Update the vertical-align WPT expectations to reflect its current shorthand
behavior.

vertical-align is now specified as a shorthand, so it should no longer
reify into specific Typed OM objects and should instead return unsupported
CSSStyleValue objects.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3552f7a1b0d5
https://hg.mozilla.org/integration/autoland/rev/e700013a5203
Enable reification for GenericCursor; r=emilio,firefox-style-system-reviewers

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e700013a5203

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/babb14ac4ada
https://hg.mozilla.org/integration/autoland/rev/236706981b3a
Add testing for additional display keyword combinations; r=emilio,firefox-style-system-reviewers,Oriol

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/60301 for changes under testing/web-platform/tests

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/236706981b3a

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9a286695eb2e
https://hg.mozilla.org/integration/autoland/rev/f57a7ed130c5
Enable reification for Display; r=emilio,firefox-style-system-reviewers

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f57a7ed130c5