2043992 - Address remaining "lime" Typed OM reification properties

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Jan Varga [:janv]]

Based on the tracking in bug 2028088 (which tracks the current CSS Typed OM WPT status in Firefox), the main remaining "lime" properties (passes-lots class on wpt.fyi) in css/css-typed-om/the-stylepropertymap/properties/ include a mix of actionable Firefox gaps and cases where Firefox is not expected to become fully green yet.

This bug focuses on the actionable cases where Chrome and Safari already pass all subtests, so improving Firefox should move the property from passes-lots to passes-all:

• border-image-outset
• border-image-slice
• border-image-width
• text-indent

This bug intentionally excludes:

• background — Safari fails the same subtests (Chrome fails some too)
• border-radius — Chrome fails the same subtests
• column-height — Safari fails the same subtests
• column-rule-style — Safari fails the same subtests
• column-rule-width — Safari fails the same subtests
• fill-color — Chrome and Safari fail the same subtests
• font-presentation — Chrome and Safari fail the same subtests
• overflow-clip-margin — Safari fails the same subtests (Chrome fails some too)
• speak — Safari fails the same subtests (Chrome fails some too)
• text-decoration-skip — Chrome and Safari fail the same subtests
• text-size-adjust — Safari fails the same subtests (Chrome fails some too)
• transition — Chrome and Safari fail the same subtests
• orphans — not currently supported in Firefox
• widows — not currently supported in Firefox
• grid — only one remaining subtest, for repeat(3, 80px) / auto-flow, which is currently unsupported in Firefox

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 2043992 - Split NonNegativeLengthOrNumberRect ToTyped implementation; r=emilio

Remove the generic Rect ToTyped derive and add explicit ToTyped implementations
for the relevant specified and computed rect aliases.

This prepares enabling Typed OM reification for border-image-outset without
accidentally enabling reification for computed values. In particular, WPT
expects computed border-image-outset values to remain unsupported even when
their serialization collapses to a single value.

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 2043992 - Enable reification for NonNegativeLengthOrNumberRect; r=emilio

border-image-outset values can now be reified into Typed OM values.

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 2043992 - Split BorderImageSlice ToTyped implementation; r=emilio

Remove the generic GenericBorderImageSlice ToTyped derive and add explicit
ToTyped implementations for the specified and computed border-image-slice
aliases.

This prepares enabling Typed OM reification for specified border-image-slice
values without accidentally enabling reification for computed values. In
particular, WPT expects computed border-image-slice values to remain
unsupported.

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 2043992 - Enable reification for BorderImageSlice; r=emilio

border-image-slice values can now be reified into Typed OM values.

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 2043992 - Enable reification for BorderImageWidth; r=emilio

border-image-width values can now be reified into Typed OM values.

Comment 6

[Jan Varga [:janv]]

Attachment: Bug 2043992 - Enable reification for GenericTextIndent; r=emilio

text-indent values can now be reified into Typed OM values.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cd4c72d37b95
https://hg.mozilla.org/integration/autoland/rev/27c2cdf6586e
Split NonNegativeLengthOrNumberRect ToTyped implementation; r=emilio,firefox-style-system-reviewers
https://github.com/mozilla-firefox/firefox/commit/dfdf0cea20c1
https://hg.mozilla.org/integration/autoland/rev/d612988ee038
Enable reification for NonNegativeLengthOrNumberRect; r=emilio,firefox-style-system-reviewers
https://github.com/mozilla-firefox/firefox/commit/3c78e22c500e
https://hg.mozilla.org/integration/autoland/rev/d83fe19c9347
Split BorderImageSlice ToTyped implementation; r=emilio,firefox-style-system-reviewers
https://github.com/mozilla-firefox/firefox/commit/94b2c59c5ff9
https://hg.mozilla.org/integration/autoland/rev/a9761dcf5589
Enable reification for BorderImageSlice; r=emilio,firefox-style-system-reviewers
https://github.com/mozilla-firefox/firefox/commit/f0ab03275ee0
https://hg.mozilla.org/integration/autoland/rev/66e13800d39e
Enable reification for BorderImageWidth; r=emilio,firefox-style-system-reviewers
https://github.com/mozilla-firefox/firefox/commit/7bc15af82d3f
https://hg.mozilla.org/integration/autoland/rev/f671196ba23b
Enable reification for GenericTextIndent; r=emilio,firefox-style-system-reviewers

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/27c2cdf6586e
https://hg.mozilla.org/mozilla-central/rev/d612988ee038
https://hg.mozilla.org/mozilla-central/rev/d83fe19c9347
https://hg.mozilla.org/mozilla-central/rev/a9761dcf5589
https://hg.mozilla.org/mozilla-central/rev/66e13800d39e
https://hg.mozilla.org/mozilla-central/rev/f671196ba23b