2041089 - [Tab Groups] Long pressing a group (grid or list) should start a multi-selection

Status: VERIFIED FIXED

(Firefox for Android :: Tabs, task)

Description

[Julie De Lorenzo [:jdelorenzo]]

Currently, long pressing a group just opens the ExpandedTabView. It should start a multi-selection action with the selected group.

Comment 1

[Julie De Lorenzo [:jdelorenzo]]

Attachment: Bug 2041089: Enable long-press to multi-select for tab groups

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ae779b146344
https://hg.mozilla.org/integration/autoland/rev/c5154e6df730
Enable long-press to multi-select for tab groups r=android-reviewers,007

Comment 3

[Julie De Lorenzo [:jdelorenzo]]

QA, could you verify that a tab group can now be multiselected through long press in list and grid view on the TabsTray?

Thank you!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b717f83c7f2b
https://hg.mozilla.org/integration/autoland/rev/d1fc305695dc
Revert "Bug 2041089: Enable long-press to multi-select for tab groups r=android-reviewers,007" for causing @InteractableGridTest.kt.

Comment 5

[agoloman]

Backed out for causing fenix failures @InteractableGridTest.kt.

• Backout link
• Push with failures
• Failure Log

Comment 6

[Julie De Lorenzo [:jdelorenzo]]

Taking a look

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9e4647a9b8a9
https://hg.mozilla.org/integration/autoland/rev/9f66f1d5f21e
Enable long-press to multi-select for tab groups r=android-reviewers,007

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9f66f1d5f21e

Comment 9

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Firefox for Android Nightly 153.0a1 from 6/10 using a Pixel 6 (Android 17).

Comment 10

[Julie De Lorenzo [:jdelorenzo]]

Attachment: Bug 2041089: Enable long-press to multi-select for tab groups

Original Revision: https://phabricator.services.mozilla.com/D302534

Comment 11

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: If declined, users will not be able to long-press to multi-select tab groups. This will only affect users who have tab groups.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: - Go to the tabs tray
• Add a tab group via multi-select, drag and drop, or debug menu
• For both list and grid mode, verify that tab groups can be long-pressed to start a multi-selection.
• Risk associated with taking this patch: medium
• Explanation of risk level: - Affects the tabs tray, which is highly visible, but only multi-selection, and is specific to tab groups, which reduces the blast radius.
• There is a feature flag for enabling/disabling tab groups.
• String changes made/needed?: No
• Is Android affected?: yes

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9596268 [details]
Bug 2041089: Enable long-press to multi-select for tab groups

This missed the cutoff for 152.0. Keeping it on the radar for a later dot release.

Comment 13

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/b829fbe60768
https://hg.mozilla.org/releases/mozilla-release/rev/6f51dfdc2608

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Added to the 152.0.2 relnotes.

Comment 15

[Mira Lobontiu (Android QA)]

Verified on the latest Firefox for Android 152.0.2 version, using a Samsung Galaxy S24 (Android 16), and a Pixel 6 (Android 17).