2041239 - Crash in [@ mozilla::net::nsHttpConnectionMgr::CheckTransInPendingQueue]

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

18 crashes from 16 installs of Firefox 153.0a1 since Happy Eyeballs v3 got enabled in Nightly in bug 2039555. Bug 2040347 landed for the same Nightly.

Crash report: https://crash-stats.mozilla.org/report/index/1321d4ad-967b-43b8-a76c-979500260521

MOZ_CRASH Reason:

MOZ_DIAGNOSTIC_ASSERT(!foundInPendingQ)

Top 10 frames:

0  xul.dll  mozilla::net::nsHttpConnectionMgr::CheckTransInPendingQueue(mozilla::net::nsH...  netwerk/protocol/http/nsHttpConnectionMgr.cpp:4058
1  xul.dll  mozilla::net::nsHttpConnectionMgr::ProcessNewTransaction(mozilla::net::nsHttp...  netwerk/protocol/http/nsHttpConnectionMgr.cpp:1911
2  xul.dll  mozilla::net::nsHttpConnectionMgr::OnMsgNewTransaction(int, mozilla::net::ARe...  netwerk/protocol/http/nsHttpConnectionMgr.cpp:2321
3  xul.dll  RefPtr<mozilla::net::nsHttpConnectionMgr>::Proxy<void, int, mozilla::net::ARe...  mfbt/RefPtr.h:356
3  xul.dll  mozilla::net::ConnEvent::Run()  netwerk/protocol/http/nsHttpConnectionMgr.cpp:180
4  xul.dll  nsThread::ProcessNextEvent(bool, bool*)  xpcom/threads/nsThread.cpp:1173
4  xul.dll  NS_ProcessNextEvent(nsIThread*, bool)  xpcom/threads/nsThreadUtils.cpp:472
5  xul.dll  mozilla::net::nsSocketTransportService::Run()  netwerk/base/nsSocketTransportService2.cpp:1254
6  xul.dll  nsThread::ProcessNextEvent(bool, bool*)  xpcom/threads/nsThread.cpp:1173
6  xul.dll  NS_ProcessNextEvent(nsIThread*, bool)  xpcom/threads/nsThreadUtils.cpp:472

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on nightly

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox153 (nightly). However, the bug still isn't assigned.

:ghess, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 2041239 - Set mTransaction=nullptr in closeTransaction so it isn't re-queued again, r=mxinden

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/79b999f9da0a
https://hg.mozilla.org/integration/autoland/rev/10c9fe251629
Set mTransaction=nullptr in closeTransaction so it isn't re-queued again, r=mxinden

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/10c9fe251629