2041274 - Make test_migration_firefoxLabsEnrollments deterministic about feature pref defaults

Status: RESOLVED WONTFIX

(Firefox :: Nimbus Desktop Client, task)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 2041274. Make test_migration_firefoxLabsEnrollments deterministic about feature pref defaults. r?#nimbus-reviewers

test_migration_firefoxLabsEnrollments only set the feature enable-prefs
it was about to enroll, leaving every other feature's enable-pref at
its channel default. That was fine while every labs feature defaulted
to false, but image.jxl.enabled is going to default to true on Nightly
(Bug 2040074), so the migration would enroll firefox-labs-jpeg-xl during
the doTest([]) iteration even though the test asserts no enrollment.

Force every feature in LABS_MIGRATION_FEATURE_MAP to true or false
explicitly at the start of each iteration (based on whether it appears
in features) and clear the user-branch values at the end so each
iteration starts clean.

The post-unenroll "user branch should be cleared" assertion has a
related but separate dependency on channel defaults: the migration
overwrites originalValue=false, so Nimbus's restore on a default-true
pref has to leave false on the user branch to override the default,
while on a default-false pref it can clean up the user branch
entirely. Make the assertion conditional on the default branch value
and add the inverse assertion for the default-true case so we cover
both shapes.

Comment 2

[Timothy Nikkel (:tnikkel)]

We're doing bug 2041397 instead of this.