2041480 - home page settings: customize wallpaper and topics lnks fail if New Tab is set to Blank Page

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Daniel Veditz [:dveditz]]

The redesigned Home Page settings has links to customize topics and wallpapers: about:newtab#customize-topics and about:newtab#customize. These links open a blank page if the user has set their New Tab to Blank Page. The wallpaper one can be reached from a button in the New Tab page itself, but I couldn't find any other way to reach customize-topics unless you know the magic URL which is never displayed to users. As a work-around for topics, users can follow, unfollow, and block topics one by one if they are shown on the New Tab page. I couldn't find a way to un-block a blocked topic without the customize-topics panel.

The fix: change the urls to about:home#customize and about:home#customize-topics instead. These always work, even if the home page was set to "Blank Page" or some specific URL.

Comment 1

[Daniel Veditz [:dveditz]]

I overlooked the bottom of the wallpaper customization panel: there IS a link to the "topics" panel from there. Everything has a workaround, it's just a broken settings experience for all the people who use blank new tabs.

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2003204

:rhamoui, since you are the author of the regressor, bug 2003204, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Reem Hamoui (PTO - back Nov 23)]

Adding in Nina as well she's been leading the settings redesign work for new tab

Comment 4

[Nina Pypchenko [:nina-py]]

I wouldn't say it's a regression - more of a UX path that was overlooked before. If users turn off Firefox Home for both new tabs and new windows, these links are hidden right now. We have a task on our todo list to adapt the UX slightly - I've linked the JIRA ticket to this bug. Might as well fix it before the next trainhop, too.

UX change expected is (taking from the JIRA ticket): Change "Manage Topics" and "Choose a Wallpaper" links to open in a New window if only New windows are set to Firefox Home.

Comment 5

[Nina Pypchenko [:nina-py]]

Attachment: Bug 2041480 - Change "Manage Topics" and "Choose a Wallpaper" links to open in a New window if only New windows are set to Firefox Home r=#home-newtab-reviewers!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f2011b960b46
https://hg.mozilla.org/integration/autoland/rev/6bb043f19fae
Change "Manage Topics" and "Choose a Wallpaper" links to open in a New window if only New windows are set to Firefox Home r=hjones,reemhamz

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/6bb043f19fae

Comment 8

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:nina-py, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox152 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Nina Pypchenko [:nina-py]]

No need to uplift - we will trainhop this change.