2041836 - Design tokens with nativeTheme values have Nova overrides ignored

Status: RESOLVED FIXED

(Toolkit :: Themes, defect, P3)

Description

[Mark Striemer [:mstriemer]]

Design tokens that have a pre-Nova nativeTheme value are having their Nova overrides ignored. This is because without the nativeTheme key set we treat the token as always being set, but if there's a nativeTheme value then we give the light/dark/default value precedence over the foundation value

Copying the pre-Nova nativeTheme value in when it's present should fix this at Figma import time, although we could likely do something when building the CSS instead (and potentially avoid defining the nativeTheme value twice)

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 2041836 - Set nativeTheme values for Nova design tokens r?#recomp-reviewers!,jooliver

This causes the value from Figma to be set for the browser theme when
necessary. We could potentially avoid some duplication by instead doing
this at CSS export time.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5c5f41a25d8f
https://hg.mozilla.org/integration/autoland/rev/e9b3ee7b2465
Set nativeTheme values for Nova design tokens r=jooliver,desktop-theme-reviewers,akulyk,emilio,thecount

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e9b3ee7b2465