Closed
Bug 2050773
Opened 25 days ago
Closed 6 days ago
Address doorhanger icons (location and email) are not visible/hard to see in dark mode
Categories
(Toolkit :: Form Autofill, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr140 | --- | unaffected |
| firefox-esr153 | --- | affected |
| firefox152 | --- | unaffected |
| firefox153 | --- | wontfix |
| firefox154 | --- | verified |
People
(Reporter: gmoldovan, Assigned: kalenlu)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: access, regression, Whiteboard: [fxcm-nova])
Attachments
(2 files)
Found in
- Nightly 154.0a1
Affected versions
- Nightly 154.0a1
Tested platforms
Affected platforms: All
Preconditions
- browser.nova.enabled = true
- browser theme is set to Dark Mode
Steps to reproduce
- Go to https://luke-chang.github.io/autofill-demo/basic.html?
- Fill out the form with valid credentials, then submit the form to trigger the "Save address?" doorhanger.
Expected result
- The icons preceding the address details and email address are fully visible.
Actual result
- The address details and email icons inside the doorhanger are dark/black, making them completely invisible or barely visible against the dark mode background.
Regression range
| Reporter | ||
Updated•25 days ago
|
Keywords: regression
Regressed by: 2041836
Comment 1•25 days ago
|
||
Set release status flags based on info from the regressing bug 2041836
:mstriemer, since you are the author of the regressor, bug 2041836, could you take a look? Also, could you set the severity field?
For more information, please visit BugBot documentation.
status-firefox152:
--- → unaffected
status-firefox153:
--- → affected
status-firefox-esr140:
--- → unaffected
Flags: needinfo?(mstriemer)
Updated•22 days ago
|
Whiteboard: [fxcm-nova]
Updated•22 days ago
|
| Assignee | ||
Updated•12 days ago
|
Assignee: nobody → klu
Comment 2•12 days ago
|
||
S3 because the meaning is still easily discernible from the content even if the visual affordance is largely missing.
Accessibility Severity: --- → s3
| Assignee | ||
Comment 3•10 days ago
|
||
Updated•10 days ago
|
Attachment #9606781 -
Attachment description: WIP: Bug 2050773 - Make address doorhanger location and email icons match text colour instead of defaulting to black in dark mode. ?mtigley → Bug 2050773 - Make address doorhanger location and email icons match text colour instead of defaulting to black in dark mode. ?mtigley
Updated•10 days ago
|
Attachment #9606781 -
Attachment description: Bug 2050773 - Make address doorhanger location and email icons match text colour instead of defaulting to black in dark mode. ?mtigley → Bug 2050773 - Make address doorhanger location and email icons match text colour instead of defaulting to black in dark mode. r?mtigley
Pushed by dgottwald@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/02110ed50408
https://hg.mozilla.org/integration/autoland/rev/930fc32e1ebd
Make address doorhanger location and email icons match text colour instead of defaulting to black in dark mode. r=desktop-theme-reviewers,mtigley,dao
Comment 5•6 days ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 days ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
Comment 6•6 days ago
|
||
The patch landed in nightly and beta is affected.
:kalenlu, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
- If no, please set
status-firefox153towontfix.
For more information, please visit BugBot documentation.
Flags: needinfo?(klu)
| Assignee | ||
Updated•6 days ago
|
Flags: needinfo?(klu)
Updated•6 days ago
|
status-firefox-esr153:
--- → affected
Flags: needinfo?(mstriemer)
You need to log in
before you can comment on or make changes to this bug.
Description
•