Remove unused items from wallet.cpp/wallet.h/singsign.cpp

RESOLVED FIXED

Status

--
trivial
RESOLVED FIXED
16 years ago
14 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

16 years ago
 
(Assignee)

Comment 1

16 years ago
Created attachment 122293 [details] [diff] [review]
patch
(Assignee)

Updated

16 years ago
Attachment #122293 - Flags: review?(dwitte)

Comment 2

16 years ago
Comment on attachment 122293 [details] [diff] [review]
patch

builds fine, warnings are gone now.

what the hell were static vars doing in a header anyway? ;)
Attachment #122293 - Flags: review?(dwitte) → review+

Comment 3

16 years ago
mvl also has a list of stuff he found was obsolete in wallet.

he promised to post it here. ;)
(Assignee)

Updated

16 years ago
Attachment #122293 - Flags: superreview?(tor)
Created attachment 122301 [details] [diff] [review]
more cleanup

With this patch, a few files can be removed: (relative to extensions/wallet)

public/nsIKeyedStreamGenerator.idl
public/nsIPasswordSink.idl
src/nsWalletBuiltInDataSources.h
src/nsBasicStreamGenerator.cpp
src/nsBasicStreamGenerator.h
src/cookie.properties
Comment on attachment 122301 [details] [diff] [review]
more cleanup

Also requesting review for the list of files.
Attachment #122301 - Flags: review?(dwitte)
src/URLFieldSchema.tbl is also unused.
Except for some deleteThisFile statements in installer files.
http://lxr.mozilla.org/seamonkey/search?string=URLFieldSchema
How long must they stay?

More unused files in cookieviewer:

cookieviewer/Makefile.in
cookieviewer/nsCookieViewer.cpp
cookieviewer/nsCookieViewer.h
cookieviewer/nsICookieViewer.idl
cookieviewer/CookieViewer.html

Comment 7

16 years ago
hmm... cookieviewer sounds fine to remove, but not sure about the ones in
comment #4.

from cvs logs:

1.1	sspitzer%netscape.com	Jan 27 2000	 	adding this interfaces, they will be
used when we make the storing
of passwords in single signon "safer".

Seth, can you shed any light on this? is this stuff cruft now, or will it still
one day have some use? is this only relevant to wallet in its current state, or
will it still be relevant to a future (possibly rewritten) wallet?

thanks ;)

Comment 8

16 years ago
Comment on attachment 122301 [details] [diff] [review]
more cleanup

hmm, since I can't seem to generate bugmail to Seth today... i'll just request
review ;)

Seth: please see comment #7.
Attachment #122301 - Flags: superreview?(sspitzer)
so, where is the work we do in nsBasicStreamGenerator::GetByte() being done now?
It seems nsBasicStreamGenerator is not build at the moment. Nothing is doing
it's work, but nothing needs it.

Thinking of it: Was the use of it to stop handing out the passwords to
consumers, but let the consumers give something the StreamGenerator puts the
password in, so the password is send to the server? (I don't know enough of
necko to know how exactly...)
And was this ever really done? Some way of preventing everything with chrome
privs to get all passwords sounds not too bad :)

Comment 11

16 years ago
i'll ask seth about this on aim sometime, but given that it was more than three
years ago i doubt we'll have much luck.

cc'ing mstoltz just in case... any idea about comment 7? specifically, any idea
why nsIKeyedStreamGenerator.idl was introduced into the tree, and whether it is
still relevant? it appears to have been introduced for a future endeavour, but
never was actually used. but if it might one day be relevant, we may want to
keep it.

in the meantime, let's whack cookieviewer.

Comment 12

16 years ago
Created attachment 124424 [details] [diff] [review]
remove cookieviewer cruft (checked in)

this patches /allmakefiles.sh to stop generation of the cookieviewer/ Makefile.

Comment 13

16 years ago
Comment on attachment 124424 [details] [diff] [review]
remove cookieviewer cruft (checked in)

requesting r/sr for the removal of some cookieviewer cruft (none of this stuff
is built or used).

this also includes the cvs removal of the following files (not included in the
diff, since one of them is large):

extensions/wallet/src/URLFieldSchema.tbl
extensions/wallet/cookieviewer/Makefile.in
extensions/wallet/cookieviewer/nsCookieViewer.cpp
extensions/wallet/cookieviewer/nsCookieViewer.h
extensions/wallet/cookieviewer/nsICookieViewer.idl
extensions/wallet/cookieviewer/CookieViewer.html
extensions/wallet/signonviewer/SignonViewer.html
extensions/wallet/walletpreview/WalletPreview.html

the html files are being removed since I believe the xul/dtd/js fu replaces
them.
Attachment #124424 - Flags: superreview?(bryner)
Attachment #124424 - Flags: review?(timeless)
Attachment #124424 - Flags: superreview?(bryner) → superreview+

Comment 14

16 years ago
for reference, applying the patch in comment 4 reduces libwallet.so by 2.1k (opt
linux build w/ stripping).

we should check there aren't any consumers of this stuff in commercial tree, or
by embeddors.
(Assignee)

Updated

16 years ago
Attachment #124424 - Flags: review?(timeless) → review+

Comment 15

16 years ago
Comment on attachment 124424 [details] [diff] [review]
remove cookieviewer cruft (checked in)

landed this one.
Attachment #124424 - Attachment description: remove cookieviewer cruft → remove cookieviewer cruft (checked in)
Regarding comment 11, I don't know what that was for. Maybe someone from the PSM
team remembers, CCing them.

Comment 17

16 years ago
see bug 26020 (yes, that old) for cleaning up the duplicate files in wallet.

Comment 18

15 years ago
Comment on attachment 122301 [details] [diff] [review]
more cleanup

r=dwitte. i'll switch the sr request over to dveditz since seth doesn't recall
the details, and dveditz is the owner.
Attachment #122301 - Flags: superreview?(sspitzer)
Attachment #122301 - Flags: superreview?(dveditz+bmo)
Attachment #122301 - Flags: review?(dwitte)
Attachment #122301 - Flags: review+

Comment 19

15 years ago
dveditz: i forgot to mention... the sr request also covers cvs removing the
related files mentioned in comment 4. (this patch removes some unused cruft from
wallet). thx!

Comment 20

15 years ago
Comment on attachment 122301 [details] [diff] [review]
more cleanup

on second thought... bryner, care to sr this? please see comments 18 & 19.
Attachment #122301 - Flags: superreview?(dveditz+bmo) → superreview?(bryner)

Updated

15 years ago
Attachment #122293 - Flags: superreview?(tor) → superreview?(bryner)
Attachment #122293 - Flags: superreview?(bryner) → superreview+
Attachment #122301 - Flags: superreview?(bryner) → superreview+

Comment 21

15 years ago
all checked in on trunk.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.