Closed Bug 2042497 Opened 3 months ago Closed 3 months ago

Remove userFeedbackCollection pref gating for Smart Window feedback UI

Categories

(Core :: Machine Learning: Frontend, task)

Product:
Core
Component:
Machine Learning: Frontend
Type:
task

Tracking

()

Status:
VERIFIED FIXED
Milestone:
153 Branch
Tracking Flags:
Tracking Status
firefox151 --- wontfix
firefox152 --- verified
firefox153 --- verified

People

(Reporter: echa, Assigned: echa)

References

Details

(Whiteboard: [aife])

Attachments

(2 files, 1 obsolete file)

Bug 2042497 - Remove userFeedbackCollection pref gating for Smart Window feedback r=#ai-frontend-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 2042497 - Remove userFeedbackCollection pref gating for Smart Window feedback
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review

Remove browser.smartwindow.userFeedbackCollection pref gate and enable the Smart Window feedback UI by default.

Blocks: 2040712
Whiteboard: [aife]
Attachment #9589851 - Attachment description: Bug 2042497 - Remove userFeedbackCollection pref gating for Smart Window feedback UI r=#ai-frontend-reviewers → Bug 2042497 - Remove userFeedbackCollection pref gating for Smart Window feedback r=#ai-frontend-reviewers
Pushed by echa@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/796942aa7621 https://hg.mozilla.org/integration/autoland/rev/29dfd7d0fe52 Remove userFeedbackCollection pref gating for Smart Window feedback r=flozia,czhou

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: We are hoping to start collecting user feedback in Smart Window. If we don't remove this pref gate, users will not be able to submit feedback.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: yes
  • Steps to reproduce for manual QE testing: - Open smart window and start chat
  • Thumbs up/ Thumbs down button should be visible on all assistant responses
  • Risk associated with taking this patch: low
  • Explanation of risk level: This feature is adding buttons to existing assistant message footer component
  • String changes made/needed?: No
  • Is Android affected?: unknown
Attachment #9590824 - Flags: approval-mozilla-beta?
Flags: qe-verify+

firefox-release Uplift Approval Request

  • User impact if declined/Reason for urgency: We are hoping to start collecting user feedback in Smart Window. If we don't remove this pref gate, users will not be able to submit feedback.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: yes
  • Steps to reproduce for manual QE testing: - Open smart window and start chat
  • Thumbs up/ Thumbs down button should be visible on all assistant responses
  • Risk associated with taking this patch: low
  • Explanation of risk level: This feature is adding buttons to existing assistant message footer component
  • String changes made/needed?: No
  • Is Android affected?: unknown
Attachment #9590837 - Flags: approval-mozilla-release?

https://hg.mozilla.org/mozilla-central/rev/29dfd7d0fe52

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox153: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch

Verified as fixed in our NIghtly 153.0a1 (2026-05-28)

QA Whiteboard: [qa-ver-needed-c153/b152]
status-firefox151: --- → affected
status-firefox152: --- → affected
status-firefox153: fixed → verified
QA Contact: rdoghi
Flags: in-testsuite+
Attachment #9590824 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9590837 - Flags: approval-mozilla-release? → approval-mozilla-release+

Reverted from release as requested

status-firefox151: fixed → wontfix
Attachment #9590837 - Attachment is obsolete: true
No longer blocks: 2034586

Verified as fixed in our latest Beta 152.0b5

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-ver-needed-c153/b152] → [qa-ver-done-c153/b152]
status-firefox152: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: