2040721 - Integrate round 1 feedback UI with Glean submission flow

Status: VERIFIED FIXED

(Core :: Machine Learning: Frontend, task)

Description

[Justin Levinsohn]

Integrate the round 1 feedback UI with the Glean feedback submission flow.

• Feedback modal submission triggers the appropriate Glean event/ping
• Integration works for:
  • thumbs up
  • thumbs down
  • checkbox reasons
  • freeform feedback text
• Feedback payload sent through Glean matches the approved round 1 schema
• Integration is gated behind pref smartwindow.user_feedback_collection

Comment 1

[echa]

Attachment: Bug 2040721 - Integrate Smart Window feedback telemetry into microsurvey submit flow r?aminomancer

• Split thumbs-up / thumbs-down into separate Spotlight message IDs and added a feedback_thumb_click Glean event to capture feedback direction on thumb click
• Added Smart Window session metadata (model, turn count, prompt version) to the feedback modal flow and routed it into the microsurvey ping on submit only
• Updated Spotlight / AboutWelcome telemetry handling so Smart Window feedback metadata is excluded from IMPRESSION/DISMISS telemetry and only recorded on submit

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fd994db9d915
https://hg.mozilla.org/integration/autoland/rev/71881c058b24
Integrate Smart Window feedback telemetry into microsurvey submit flow r=aminomancer,omc-reviewers,jlewis

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ccbf7f57bc23
https://hg.mozilla.org/integration/autoland/rev/90597e773dc4
Revert "Bug 2040721 - Integrate Smart Window feedback telemetry into microsurvey submit flow r=aminomancer,omc-reviewers,jlewis" for causing bc failures @ browser_aiwindow_smartbar_telemetry

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_aiwindow_smartbar_telemetry

Backout link: https://hg.mozilla.org/integration/autoland/rev/90597e773dc4ae98dcb02deac9fa68e38cea539f

Push with failures

Failures log ->TEST-UNEXPECTED-FAIL | browser/components/aiwindow/ui/test/browser/browser_aiwindow_smartbar_telemetry.js

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1c5d08f67bae
https://hg.mozilla.org/integration/autoland/rev/b6b085c2f458
Integrate Smart Window feedback telemetry into microsurvey submit flow r=aminomancer,omc-reviewers,jlewis

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b6b085c2f458

Comment 7

[BugBot [:suhaib / :marco]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 8

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: We are hoping to start collecting user feedback data for Smart Window as soon as possible as it is important for future development.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: - Open new Smart Window and enable pref browser.smartwindow.userFeedbackCollection
• Start chat and click "thumbs up" or "thumbs down" to submit feedback
• verify feedback is being sent to glean
• Risk associated with taking this patch: low
• Explanation of risk level: Low, currently user feedback collection is hidden behind pref
• String changes made/needed?: no
• Is Android affected?: unknown

Comment 9

[echa]

Attachment: Bug 2040721 - Integrate Smart Window feedback telemetry into microsurvey submit flow

• Move Smart Window feedback modal configs into OnboardingMessageProvider and fetch them via ASRouter
• Update Spotlight / AboutWelcome telemetry handling to inject and record smart_window_user_feedback_data on microsurvey pings

Original Revision: https://phabricator.services.mozilla.com/D301620

Comment 10

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: We are hoping to start collecting user feedback data for Smart Window as soon as possible as it is important for future development.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: - Open new Smart Window and enable pref browser.smartwindow.userFeedbackCollection
• Start chat and click "thumbs up" or "thumbs down" to submit feedback
• verify feedback is being sent to glean
• Risk associated with taking this patch: low
• Explanation of risk level: Low, currently user feedback collection is hidden behind pref
• String changes made/needed?: no
• Is Android affected?: unknown

Comment 11

[echa]

Attachment: Bug 2040721 - Integrate Smart Window feedback telemetry into microsurvey submit flow

• Move Smart Window feedback modal configs into OnboardingMessageProvider and fetch them via ASRouter
• Update Spotlight / AboutWelcome telemetry handling to inject and record smart_window_user_feedback_data on microsurvey pings

Original Revision: https://phabricator.services.mozilla.com/D301620

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/b1858eabacfd
https://hg.mozilla.org/releases/mozilla-beta/rev/2d2625334de3

Comment 13

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 152.0b4 and our latest Nightly 153.0a1 (2026-05-26)

Comment 14

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/362f02874507
https://hg.mozilla.org/releases/mozilla-release/rev/631d8c7c4e86

Comment 15

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/960f064acc3f
https://hg.mozilla.org/releases/mozilla-release/rev/313a9065c130

Comment 16

[Donal Meehan [:dmeehan]]

Backed out of release, since Bug 2036193 had to be backout due to CI failures

Comment 17

[Rares Doghi, Desktop QA]

Updating the main status flag.