2042865 - Add test coverage for history grid thumbnails

Status: RESOLVED FIXED

(Core :: Machine Learning: Frontend, task)

Description

[Justin Levinsohn]

Add automated test coverage for history grid thumbnails.

• Add tests covering core history grid thumbnail behavior
• Test coverage includes:
  • thumbnail rendering
  • fallback behavior
  • grid/list behavior where applicable
  • loading/error states where applicable
• Tests validate expected behavior for common and edge-case scenarios
• Existing history grid functionality continues to pass

Notes

• Exact test coverage approach (unit/integration/browser tests) can be determined during implementation

Comment 1

[:omarg]

Attachment: Bug 2042865 - add test coverage for history thumbnail grid

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/96d7d82a95ba
https://hg.mozilla.org/integration/autoland/rev/dd0e16a5a10a
add test coverage for history thumbnail grid r=echa

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3412b182fbbd
https://hg.mozilla.org/integration/autoland/rev/0aab778d1b5d
Revert "Bug 2042865, Bug 2038073, Bug 2038069, Bug 2038071 - add test coverage for history thumbnail grid r=echa" for causing bc failures at browser_aichat_message.js

Comment 4

[rperta]

Backed out for causing multiple failures(4 logs attached)
Backout link
Push with failures
Failure log(s)
2Failure log(s)
3Failure log(s)
4Failure log(s)

Comment 5

[:omarg]

Test failures fixed

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/931ce81d92cc
https://hg.mozilla.org/integration/autoland/rev/8d151a5dfc47
add test coverage for history thumbnail grid r=echa

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0387be9ec18d
https://hg.mozilla.org/integration/autoland/rev/6e9fd652c651
Revert "Bug 2042865, Bug 2038073, Bug 2038069, Bug 2038071 - add test coverage for history thumbnail grid r=echa"for causing bc failures at browser/browser_smartwindow_history_thumbnails.js

Comment 8

[rperta]

Backed out for causing bc failures at browser/browser_smartwindow_history_thumbnails.js
Backout link
Push with failures
Failure log(s)

Comment 9

[:omarg]

This test was marked as intermittent here: https://bugzilla.mozilla.org/show_bug.cgi?id=2046533

Which I was already working on in a branch, I guess I will move these test updates to the patch that adds this test instead.

Comment 10

[:omarg]

re-landing, try builds no longer showed telemetry test time outs or any failures for browser_smartwindow_history_thumbnails.js

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d8a861852c4b
https://hg.mozilla.org/integration/autoland/rev/a3e40eb02725
add test coverage for history thumbnail grid r=echa

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a3e40eb02725

Comment 13

[:omarg]

Attachment: Bug 2042865 - add test coverage for history thumbnail grid a=RyanVM

Original Revision: https://phabricator.services.mozilla.com/D303246

Comment 14

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: Smart Window improvement
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: - Open Smart Window tab
• Prompt for a browsing history search like "show sites in browsing history"
• Should display results in a grid/list view instead of a bullet list
• Risk associated with taking this patch: medium
• Explanation of risk level: Enhances response from LLM - should leave unrelated to browsing history lists untouched, should render browsing history lists as new grid/list component
• String changes made/needed?: n/a
• Is Android affected?: no

Comment 15

[Brindusa Tot, DTE]

This is for automated tests. Removing the qe-verify+ flag.

Comment 16

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/c67f9e74a947
https://hg.mozilla.org/releases/mozilla-release/rev/e7b162321939

Comment 17

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/ce97811c7979
https://hg.mozilla.org/releases/mozilla-release/rev/49539315c210

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Stack backed out for various bustage issues (besides the one I'd already pushed a follow-up for). Please make sure the stack is green on Try before attempting to uplift again.
https://treeherder.mozilla.org/logviewer?job_id=573790971&repo=mozilla-release&task=TlM-urucRA6m-9AnP0PDHg.0&lineNumber=114740
https://treeherder.mozilla.org/logviewer?job_id=573788710&repo=mozilla-release&task=bcTjGEAdQ3SU_6bQf6w0hQ.0&lineNumber=386
https://treeherder.mozilla.org/logviewer?job_id=573788680&repo=mozilla-release&task=RB1axZwsSM2BnTrUq9qSJw.0&lineNumber=1089

Comment 19

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/da2456ef514d
https://hg.mozilla.org/releases/mozilla-release/rev/363580aab59b
https://github.com/mozilla-firefox/firefox/commit/4e0a476dbf05
https://hg.mozilla.org/releases/mozilla-release/rev/271c934a6321

Comment 20

[:omarg]

Pushed new revisions to stack after fixing the issues, here's my try build results: https://treeherder.mozilla.org/jobs?repo=try&revision=0e5a6db5944031348b5223b3afedd1aacb82a7e5

Comment 21

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/6bc6c29c28a4
https://hg.mozilla.org/releases/mozilla-release/rev/950ba1a60e43