2042957 - JsepSessionImpl is associating transceivers with remote sendonly/inactive m-sections

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Byron Campen [:bwc]]

We should only do this for sendrecv/recvonly, see https://datatracker.ietf.org/doc/html/rfc8829#section-5.10-6.6.2.2.2.1

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 2042957 - Add WPT for checking that a sendrecv transceiver doesn't bind to a remote sendonly m-section. r?#webrtc-reviewers

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

STR: https://jsfiddle.net/jib1/5bvoafmx/31/ (should produce mic audio in a visualizer)

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 2042957 - Add gtests for binding sending addTrack transceivers to remote m-sections. r?#webrtc-reviewers

Comment 4

[Byron Campen [:bwc]]

Attachment: Bug 2042957: Only attempt to associate transceivers when remote m-section is receiving. r?dbaker

Comment 5

[Byron Campen [:bwc]]

Attachment: Bug 2042957: Stop using FindUnassociatedTransceiver on application m-sections. r?dbaker

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6807710434e4
https://hg.mozilla.org/integration/autoland/rev/aae8b39d446d
Add WPT for checking that a sendrecv transceiver doesn't bind to a remote sendonly m-section. r=webrtc-reviewers,jib
https://github.com/mozilla-firefox/firefox/commit/ad3712285d4d
https://hg.mozilla.org/integration/autoland/rev/147221988098
Add gtests for binding sending addTrack transceivers to remote m-sections. r=webrtc-reviewers,bwc
https://github.com/mozilla-firefox/firefox/commit/408d89cfb809
https://hg.mozilla.org/integration/autoland/rev/77360fe8b32f
Only attempt to associate transceivers when remote m-section is receiving. r=dbaker
https://github.com/mozilla-firefox/firefox/commit/0e1e2bb02847
https://hg.mozilla.org/integration/autoland/rev/c67de44c5152
Stop using FindUnassociatedTransceiver on application m-sections. r=dbaker

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/aae8b39d446d
https://hg.mozilla.org/mozilla-central/rev/147221988098
https://hg.mozilla.org/mozilla-central/rev/77360fe8b32f
https://hg.mozilla.org/mozilla-central/rev/c67de44c5152

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/60271 for changes under testing/web-platform/tests

Comment 9

[Byron Campen [:bwc]]

Unsure whether this is worth an ESR uplift. Let's wait on uplift until next week, in case there's services that break.

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot