2043881 - Time picker opened with invalid value changes to another potentially invalid value

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P3)

Description

[Sam Johnson]

Currently, when the time picker is opened, and the current value is invalid, there is logic to instead select the first item in the picker. However, this does not consider the min value, meaning another potentially invalid time is being selected anyway. When the date picker is in this situation, it displays the closest valid month.

Comment 1

[Sam Johnson]

Attachment: Bug 2043881 - When opening time picker with invalid value, select lowest valid value instead of first item. r?#recomp-reviewers

Currently, when the time picker is opened, and the current value is invalid, there is logic to instead select the first item in the picker. However, this does not consider the min value, meaning another potentially invalid time is being selected anyway. Selecting the minimum valid value instead provides a better experience, and setting it in timeKeeper instead avoids surprise scrolling animations when component state does not match timeKeeper state.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1db4a53974e5
https://hg.mozilla.org/integration/autoland/rev/16bc4e6a924f
When opening time picker with invalid value, select lowest valid value instead of first item. r=jules

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/16bc4e6a924f