2043929 - Migrate Fenix version codes and BuildConfig off the legacy AGP variant API

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, task)

Description

[Ryan VanderMeulen [:RyanVM]]

AGP 9 removes the applicationVariants API that Fenix uses to set per-output version codes/names and per-variant BuildConfig fields. As preparatory work for the AGP 9 upgrade (bug 2043921), move the version code and name overrides to androidComponents.onVariants (reading the ABI from output.filters), and relocate the BuildConfig field definitions onto defaultConfig, with the debug build type overriding the fields that differ. The coverage jacoco report wiring also moves to onVariants.

The new APIs are already valid on AGP 8.13. The generated BuildConfig.java and per-channel version codes are preserved (verified byte-identical for debug/nightly and on a try push for the per-ABI splits).

Try: https://treeherder.mozilla.org/jobs?repo=try&revision=6de8fc758ae1d94b60207a2324989d11b4f43ad8

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 2043929 - Migrate Fenix version codes and BuildConfig off the legacy AGP variant API r?ahochheiden,#android-reviewers

AGP 9 removes the applicationVariants API. Move the per-output version code and name overrides to
androidComponents.onVariants, and relocate the BuildConfig field definitions onto defaultConfig (with the
debug build type overriding the ones that differ), which keeps the raw-literal buildConfigField API and
preserves the generated values. The coverage jacoco report wiring also moves to onVariants.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7cd767b69829
https://hg.mozilla.org/integration/autoland/rev/9ce668fa3f14
Migrate Fenix version codes and BuildConfig off the legacy AGP variant API r=ahochheiden,android-reviewers,adhingra

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9ce668fa3f14