Closed Bug 2044091 Opened 5 months ago Closed 5 months ago

Sports widget: reorder pager cards to lead with celebrations and bracket finishers

Categories

(Firefox for Android :: Homepage, enhancement)

All
Android
enhancement

Tracking

()

RESOLVED FIXED
153 Branch
Tracking Status
firefox151 --- fixed
firefox152 --- fixed
firefox153 --- fixed

People

(Reporter: skhan, Assigned: skhan)

References

Details

(Whiteboard: [fxdroid][group3][world-cup-phase2])

Attachments

(3 external files)

The sports widget pager currently sorts cards in three coarse buckets (LIVE > PAST > UPCOMING) with chronological order within each. This buries the most-relevant cards in several end-of-tournament scenarios.

Desired ordering (single rule for both followed-team and no-team views):

  1. Live matches (chronological)
  2. Champion card — Final decided with TournamentWinner outcome
  3. Third Place card — TPP decided with ThirdPlace outcome (independent of #2)
  4. Upcoming bracket-finishing matches by date (TPP Sat before Final Sun)
  5. Past matches reverse-chronologically (newest first), excluding any card pinned above
  6. Other upcoming matches chronologically

Scenarios this should fix:

  • Follow team in Final, Final ended -> Champion -> Third Place -> SF -> QF -> R16 -> Group (currently champion is last)
  • No team, Final ended -> Champion -> Third Place (currently TPP before Final because TPP is Saturday)
  • Follow team, Final live, TPP decided -> Live Final -> Third Place -> SF -> QF -> R16 -> Group (currently past is oldest-first so Group comes first)
  • Follow team in Final, Friday before kickoff -> Upcoming TPP -> Upcoming Final -> SF -> QF -> R16 -> Group (currently bracket finishers are at the end)
  • No team, Saturday after TPP -> Third Place -> Upcoming Final (currently TPP is in past bucket which appears before upcoming)

Lives in MatchCardBuilder.orderedForPager. Should pass 7 scenario tests added to MatchCardBuilderTest.

The pager previously sorted cards into three coarse buckets (LIVE > PAST >
UPCOMING) with chronological order within each. This buried the most-relevant
cards in several end-of-tournament scenarios -- the champion card landed last
in a long followed-team pager; an upcoming Final the user's team is about to
play landed at the very end; and the no-team view showed TPP before Final
purely because Saturday precedes Sunday.

Replace orderedForPager with a single rule applied to both views:

  1. Live matches (chronological)
  2. Champion card (Final decided, TournamentWinner outcome)
  3. Third Place card (TPP decided, ThirdPlace outcome; independent of #2)
  4. Upcoming bracket-finishing matches by date (TPP Sat before Final Sun)
  5. Other past matches reverse-chronologically, so the team's most recent KO
    round sits next to the celebrations rather than buried under group-stage
    history
  6. Other upcoming matches chronologically

Adds seven scenario tests covering the followed-team and no-team paths
across the pre-tournament, mid-tournament, between-TPP-and-Final, and
post-Final phases.

Assignee: nobody → skhan
Status: NEW → ASSIGNED
Pushed by skhan@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b532fb2d49fe https://hg.mozilla.org/integration/autoland/rev/8dce3c351a1f Reorder sports widget pager cards to lead with celebrations and bracket finishers r=android-reviewers,moyin
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Regressions: 2044649

The pager previously sorted cards into three coarse buckets (LIVE > PAST >
UPCOMING) with chronological order within each. This buried the most-relevant
cards in several end-of-tournament scenarios -- the champion card landed last
in a long followed-team pager; an upcoming Final the user's team is about to
play landed at the very end; and the no-team view showed TPP before Final
purely because Saturday precedes Sunday.

Replace orderedForPager with a single rule applied to both views:

  1. Live matches (chronological)
  2. Champion card (Final decided, TournamentWinner outcome)
  3. Third Place card (TPP decided, ThirdPlace outcome; independent of #2)
  4. Upcoming bracket-finishing matches by date (TPP Sat before Final Sun)
  5. Other past matches reverse-chronologically, so the team's most recent KO
    round sits next to the celebrations rather than buried under group-stage
    history
  6. Other upcoming matches chronologically

Adds seven scenario tests covering the followed-team and no-team paths
across the pre-tournament, mid-tournament, between-TPP-and-Final, and
post-Final phases.

Original Revision: https://phabricator.services.mozilla.com/D303821

Attachment #9593729 - Flags: approval-mozilla-release?

The pager previously sorted cards into three coarse buckets (LIVE > PAST >
UPCOMING) with chronological order within each. This buried the most-relevant
cards in several end-of-tournament scenarios -- the champion card landed last
in a long followed-team pager; an upcoming Final the user's team is about to
play landed at the very end; and the no-team view showed TPP before Final
purely because Saturday precedes Sunday.

Replace orderedForPager with a single rule applied to both views:

  1. Live matches (chronological)
  2. Champion card (Final decided, TournamentWinner outcome)
  3. Third Place card (TPP decided, ThirdPlace outcome; independent of #2)
  4. Upcoming bracket-finishing matches by date (TPP Sat before Final Sun)
  5. Other past matches reverse-chronologically, so the team's most recent KO
    round sits next to the celebrations rather than buried under group-stage
    history
  6. Other upcoming matches chronologically

Adds seven scenario tests covering the followed-team and no-team paths
across the pre-tournament, mid-tournament, between-TPP-and-Final, and
post-Final phases.

Original Revision: https://phabricator.services.mozilla.com/D303821

Attachment #9593747 - Flags: approval-mozilla-beta?
Flags: in-testsuite+
Attachment #9593747 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9593729 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: