Closed Bug 2044649 Opened 5 months ago Closed 5 months ago

Sports widget: upcoming Final and Third Place shown first in pager during group stage

Categories

(Firefox for Android :: Homepage, defect)

All
Android
defect

Tracking

()

RESOLVED FIXED
153 Branch
Tracking Status
firefox151 --- fixed
firefox152 --- fixed
firefox153 --- fixed

People

(Reporter: skhan, Assigned: skhan)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [fxdroid][group3][world-cup-phase2])

Attachments

(3 external files)

Follow-up to bug 2044091 (pager reordering).

In the no-team pager, the Final and Third Place playoff are always carried (pinned by BRACKET_FINISHING_STAGES in SportsWidgetMiddleware) so their schedule stays visible. After the reordering change, the "upcoming bracket-finishing" segment was placed ahead of past and other-upcoming cards unconditionally.

Result: during the group stage, the upcoming Final and Third Place (weeks away) are displayed as the FIRST cards in the pager, ahead of the group matches being played now.

Fix in MatchCardBuilder.orderedForPager: pin the upcoming Final / Third Place to the front only when there are no other upcoming matches (i.e. they are genuinely the next matches up, late in the tournament). While earlier rounds still have upcoming games, the finals sort by date into their natural place at the tail.

The end-of-tournament scenarios (Friday/Saturday before the finals) are unaffected, since at that point there are no other upcoming matches and the finals correctly lead. Added a regression test asserting GROUP, GROUP, THIRD_PLACE_PLAYOFF, FINAL order during the group stage.

Follow-up to Bug 2044091. The no-team pager always carries the Final and
Third Place playoff (pinned by BRACKET_FINISHING_STAGES) so their schedule
stays visible. The reordering change placed the upcoming bracket-finishing
segment ahead of past and other-upcoming cards unconditionally, so during the
group stage the finals -- still weeks away -- led the pager ahead of the group
matches being played now.

Pin the upcoming Final / Third Place to the front only when there are no other
upcoming matches, i.e. when they are genuinely the next matches up late in the
tournament. While earlier rounds still have upcoming games, the finals sort by
date into their natural place at the tail.

The end-of-tournament scenarios are unaffected: at that point there are no
other upcoming matches, so the finals still lead. Adds a regression test
asserting the group-stage order keeps the finals last.

Assignee: nobody → skhan
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 2044091

Pushed by skhan@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/4e2398ce4354 https://hg.mozilla.org/integration/autoland/rev/0b90a1854a74 Don't lead the sports pager with the Final and Third Place during the group stage r=android-reviewers,moyin
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch

Follow-up to Bug 2044091. The no-team pager always carries the Final and
Third Place playoff (pinned by BRACKET_FINISHING_STAGES) so their schedule
stays visible. The reordering change placed the upcoming bracket-finishing
segment ahead of past and other-upcoming cards unconditionally, so during the
group stage the finals -- still weeks away -- led the pager ahead of the group
matches being played now.

Pin the upcoming Final / Third Place to the front only when there are no other
upcoming matches, i.e. when they are genuinely the next matches up late in the
tournament. While earlier rounds still have upcoming games, the finals sort by
date into their natural place at the tail.

The end-of-tournament scenarios are unaffected: at that point there are no
other upcoming matches, so the finals still lead. Adds a regression test
asserting the group-stage order keeps the finals last.

Original Revision: https://phabricator.services.mozilla.com/D304423

Attachment #9593731 - Flags: approval-mozilla-release?

Follow-up to Bug 2044091. The no-team pager always carries the Final and
Third Place playoff (pinned by BRACKET_FINISHING_STAGES) so their schedule
stays visible. The reordering change placed the upcoming bracket-finishing
segment ahead of past and other-upcoming cards unconditionally, so during the
group stage the finals -- still weeks away -- led the pager ahead of the group
matches being played now.

Pin the upcoming Final / Third Place to the front only when there are no other
upcoming matches, i.e. when they are genuinely the next matches up late in the
tournament. While earlier rounds still have upcoming games, the finals sort by
date into their natural place at the tail.

The end-of-tournament scenarios are unaffected: at that point there are no
other upcoming matches, so the finals still lead. Adds a regression test
asserting the group-stage order keeps the finals last.

Original Revision: https://phabricator.services.mozilla.com/D304423

Attachment #9593749 - Flags: approval-mozilla-beta?
Flags: in-testsuite+
Attachment #9593749 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9593731 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: