2044164 - Add smooth transition for Assistant sidebar open/close

Status: RESOLVED FIXED

(Core :: Machine Learning: Frontend, enhancement)

Description

[Justin Levinsohn]

Add a smooth transition when the Assistant sidebar opens and closes.

• Assistant sidebar animates in when opened
• Assistant sidebar animates out when closed
• Transition feels smooth and does not appear instant or jarring
• Animation is consistent with existing Firefox sidebar behavior where appropriate
• Reuse classic sidebar animation pattern if feasible

Comment 1

[:jlewis]

Attachment: Bug 2044164 - Add smooth transition for Assistant sidebar open/close r=#ai-frontend-reviewers

Comment 3

[:jlewis]

Here is the follow-up to move towards the View Transition API: https://bugzilla.mozilla.org/show_bug.cgi?id=2049479

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d59d7e218cdd
https://hg.mozilla.org/integration/autoland/rev/b6f99e60828b
Add smooth transition for Assistant sidebar open/close r=desktop-theme-reviewers,tabbrowser-reviewers,ngrato,sthompson,emilio

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6fd7369be42c
https://hg.mozilla.org/integration/autoland/rev/a74e7d925809
Revert "Bug 2044164 - Add smooth transition for Assistant sidebar open/close r=desktop-theme-reviewers,tabbrowser-reviewers,ngrato,sthompson,emilio" for causing bc failures @ browser_aiwindow_ask_button.js

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_aiwindow_ask_button.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/a74e7d925809b021a39dc61926ab4e6cb861f6fb

Push with failures

Failures log ->browser_aiwindow_ask_button.js

Comment 7

[:jlewis]

Thanks, had to update a test to accommodate state transition (200ms)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3a008d964d93
https://hg.mozilla.org/integration/autoland/rev/21d12fbc5eb3
Add smooth transition for Assistant sidebar open/close r=desktop-theme-reviewers,tabbrowser-reviewers,ngrato,sthompson,emilio

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/548f896dfb87
https://hg.mozilla.org/integration/autoland/rev/401f809adde8
Revert "Bug 2044164 - Add smooth transition for Assistant sidebar open/close r=desktop-theme-reviewers,tabbrowser-reviewers,ngrato,sthompson,emilio" for causing bc failures @ browser_aiwindow_urlbar_chat.js

Comment 10

[pstanciu]

Backed out for causing bc failures @ browser_aiwindow_urlbar_chat.js

• https://hg.mozilla.org/integration/autoland/rev/401f809adde819cdc715f8e3e60cdf0609af96a0
• Push with failures
• Failure Log

Comment 11

[:jlewis]

Fixed some flaky tests that were passing locally but were pushed over the edge here. Apologies and thanks!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/496443502c0f
https://hg.mozilla.org/integration/autoland/rev/6a52cd94fc04
Add smooth transition for Assistant sidebar open/close r=desktop-theme-reviewers,tabbrowser-reviewers,ngrato,sthompson,emilio

Comment 13

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6a52cd94fc04