Nova floating chrome: smart window box
Categories
(Firefox :: Tabbed Browser, task, P3)
Tracking
()
People
(Reporter: sthompson, Unassigned)
References
Details
(Whiteboard: [fidefe-nova])
https://www.figma.com/design/9Lqoh8evbovlSdOq47tA54/~Nova~-Smart-Window-Library---Specs?node-id=3163-20839&t=fGNp1PzAy1dVZpds-0 shows the Smart Window's #ai-window-box in place. https://www.figma.com/design/9Lqoh8evbovlSdOq47tA54/~Nova~-Smart-Window-Library---Specs?node-id=104-1452&t=fGNp1PzAy1dVZpds-0 defines that component in Figma.
In D293109, Jeremy noted that the AI window splitter and box elements are in the #browser flex order but use visibility:collapse so that even when those elements are not shown, the gaps between them are still rendered.
It's not super clear to me from the Smart Window Nova spec what is expected from the AI box, but there may be a reason why that team avoided display: none. We should reach out to the Smart Window team to understand what they want to do.
|
||
Updated•3 months ago
|
|
||
Comment 1•2 months ago
|
||
Justin, would this make sense for your team to pick up since you have the custom sidebar in smart window? If so, Jswinarton is a good person to talk to about this.
|
||
Comment 2•2 months ago
|
||
Hey, smart window engineer here.
If I remember right, we want the smart window splitter to be noticeable only when we hover over it as we see both the different cursor and the background hover state. However, we use its width so the smartbar have equal spacing on each side of the sidebar.
Seems like this ticket would benefit from being worked after the urlbar and the page content have their detached style for Nova, but after those have been worked on we might be able to work on it ourselves.
Right now it's not very clear to me which changes are part of the smart window sidebar and which we will get for free. Does that make sense to you?
Adding a transition for the open/close of the Smart Window sidebar here:
https://bugzilla.mozilla.org/show_bug.cgi?id=2044164
https://phabricator.services.mozilla.com/D303953
We'd like to avoid display: none-ing to animate/transition the sidebar opened closed. Could we keep them collapsed and widen the #tabbrowser-tabbox (negative margin on inline-end) by the gap amount to handle the gaps-still-showing issue?
|
Reporter | |
Comment 4•1 month ago
|
||
Approved the patch on bug 2044164, I think that's a fine approach.
Description
•