2044192 - Remove about:config pref image.natural-size-fallback.enabled

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, task)

Description

[Daniel Holbert [:dholbert]]

Before we fix bug 2033633, we should probably remove the about:config pref that guards its code, to simplify things a bit.

That about:config pref (which guarded the new code that I added in bug 1965560 last year) has been shipping as true for over a year now (since bug 1969753 landed), so it's pretty solidly shipped and we're unlikely to want to revert it to the previous value at this point, given that the prior codepath is now solidly against the spec and causes site breakage.

Things to do here:

• Remove the image.natural-size-fallback.enabled block from modules/libpref/init/StaticPrefList.yaml
  https://searchfox.org/firefox-main/rev/e28b34ab33dbf49364999070168cbb7e11e8e5bd/modules/libpref/init/StaticPrefList.yaml#8837-8843
• Delete this file which only exists to set that pref to true for tests (which was important before the pref defaulted to true):
  https://searchfox.org/firefox-main/rev/e28b34ab33dbf49364999070168cbb7e11e8e5bd/testing/web-platform/meta/html/semantics/embedded-content/the-img-element/__dir__.ini
• Delete these two C++ checks for this pref, deleting/simplifying surrounding code to assume that the pref-check is now unconditionally 'true' (i.e. we're definitely sticking with the new behavior that the pref was controlling)
  https://searchfox.org/firefox-main/search?q=natural_size_fallback&path=

Comment 1

[Katherine Ye [:kyoety]]

Attachment: Bug 2044192 - Remove image.natural-size-fallback.enabled. r=dholbert

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/24c53e55deb2
https://hg.mozilla.org/integration/autoland/rev/a265ff9fed6d
Remove image.natural-size-fallback.enabled. r=dholbert

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5ac5fc0b11de
https://hg.mozilla.org/integration/autoland/rev/5485fd26a493
Revert "Bug 2044192 - Remove image.natural-size-fallback.enabled. r=dholbert" for causing wpt failures

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/5485fd26a493f03aeabcb83d43df3bccbee0151c

Push with failures

Failure log ->TEST-UNEXPECTED-FAIL | /html/semantics/embedded-content/the-img-element/naturalWidth-naturalHeight-width-height.html

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/897c709f2d9a
https://hg.mozilla.org/integration/autoland/rev/26080a272629
Remove image.natural-size-fallback.enabled. r=dholbert

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e1ff9de076c4
https://hg.mozilla.org/integration/autoland/rev/412e14f227a5
Revert "Bug 2044192 - Remove image.natural-size-fallback.enabled. r=dholbert" for causing wpt failures @ naturalWidth-naturalHeight-width-height.html

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures @ naturalWidth-naturalHeight-width-height.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/412e14f227a557fe3f154ca881020f1558ef5ccf

Push with failures

Failure log ->TEST-UNEXPECTED-FAIL | /html/semantics/embedded-content/the-img-element/naturalWidth-naturalHeight-width-height.html | SVG image, with natural width (with srcset/2x) (when not rendered)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3425aadd3da9
https://hg.mozilla.org/integration/autoland/rev/40894a27efe8
Remove image.natural-size-fallback.enabled. r=dholbert

Comment 9

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/40894a27efe8