Closed Bug 2044205 Opened 5 months ago Closed 4 months ago

Evolve border radius token scale

Categories

(Toolkit :: Themes, task)

task

Tracking

()

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: jules, Assigned: jules)

References

(Depends on 1 open bug)

Details

(Whiteboard: [recomp-nova])

Attachments

(1 external file)

In order to support new designs for Nova and Smart Window, we need to introduce 12px in our border radius scale, and add 24px.
Note that 12px is tricky because it will be sandwiched between 8px and 16px and require quite a bit of finding-and-replacing.

Additionally, we had discussed potentially removing any roundness no longer used for the new designs. I audited the Nova Components Figma library and noticed that --border-radius-xsmall (2px) is used quite a bit in code but doesn't have any use in modern designs. We could look into removing and shifting the scale but we'd need to look at existing its usage.

Depends on: 2030460
Assignee: nobody → jules
Attachment #9592353 - Attachment description: WIP: Bug 2044205 - Evolve border radius scale → Bug 2044205 - Evolve border radius scale r?mstriemer
Status: NEW → ASSIGNED
Whiteboard: [recomp]
Blocks: 2031910
Attachment #9592353 - Attachment description: Bug 2044205 - Evolve border radius scale r?mstriemer → WIP: Bug 2044205 - Evolve border radius scale r?mstriemer
Attachment #9592353 - Attachment description: WIP: Bug 2044205 - Evolve border radius scale r?mstriemer → Bug 2044205 - Evolve border radius scale r?mstriemer
Blocks: 2030460
No longer depends on: 2030460
Whiteboard: [recomp] → [recomp-nova]
Pushed by jsimplicio@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/9c9c9bb1f910 https://hg.mozilla.org/integration/autoland/rev/885424ad96ba Evolve border radius scale r=mstriemer,desktop-theme-reviewers,maxx,yjamora,mossop,dao,urlbar-reviewers
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
Depends on: 2050600
No longer depends on: 2050600
Regressions: 2050600
Duplicate of this bug: 2030460
QA Whiteboard: [qa-triage-done-c155/b154]
Depends on: 2085783
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: