Open Bug 2085783 Opened 24 days ago Updated 9 hours ago

[Nova] PiP toggle button in videos still has old less-rounded appearance compared with video overlay buttons (border radius)

Categories

(Toolkit :: Picture-in-Picture, defect, P2)

Firefox 161
defect

Tracking

()

Tracking Status
firefox161 --- affected

People

(Reporter: ke5trel, Assigned: vstepanov)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [fidefe-pip])

Attachments

(1 file, 1 external file)

STR:

  1. Launch latest Nightly 161.0a1.
  2. Open a video.
  3. Hover the mouse cursor over video and note Picture-in-Picture (PiP) toggle button appearance.
  4. Click the PiP toggle button and note the player overlay button appearance.

Expected:
PiP toggle button has same 8px border radius as the PiP player overlay control buttons (--border-radius-small: 8px).

Actual:
PiP toggle button still has old 4px border radius (--pip-border-radius-toggle: 4px).

Bug 2044205 increased the border radius affecting PiP player controls for Nova.

Thanks for flagging this. Bug 2044205 did not address the video toggle since it was not covered by the spec. I'll reach out to our UX partners for input.

Severity: -- → S3
Priority: -- → P2
Whiteboard: [fidefe-pip]

After consulting UX, we're leaning towards a 12px border-radius for the PiP window buttons (ignoring the playback speed panel and sliders) and PiP toggle (small and expanded versions).

Assignee: nobody → kpatenio
Assignee: kpatenio → nobody
Assignee: nobody → vstepanov

Hi vstepanov, thanks for picking up this bug.

Here's some information that might help:

The expanded variant is shown for videos that have never opened PiP before. The small one, on the other hand, is shown if PiP has already been used multiple times.

If you have any questions about the bug or just PiP in general, don't hesitate to reach out (preferably through Slack).

Flags: needinfo?(vstepanov)

Hi Katherine,
Thank you for the guidance! That helps a lot.

Flags: needinfo?(vstepanov)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: