Closed Bug 2044386 Opened 5 months ago Closed 4 months ago

Change selected value when hiding currently selected value in manual config

Categories

(Thunderbird :: Account Manager, defect, P1)

defect
Points:
2

Tracking

(Not tracked)

RESOLVED FIXED
153 Branch

People

(Reporter: freaktechnik, Assigned: vineet)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

This was probably regressed a while ago, maybe when we switched to select actually. Either way, when we hide the oauth option, the select value doesn't switch to an available method when oauth was selected. We can either extend the account-hub-select to manage this for us, or we can update the oauth visibility handling (in both incoming and outgoing, and maybe the new flow too) to account for this, and also update the selected value when necessary.

There is one case where this is already handled, which is the #updateConfigInputsVisibility when switching to an exchange protocol. It will then force 3 (cleartext password) to be selected if an invalid option for exchange is selected.

STR:

  1. Go to manual email account config in account hub
  2. Enter a hostname that has oauth available (for example gmail.com)
  3. Select oauth in the auth method
  4. Change the hostname to one without oauth support (for example example.com)

Actual result: OAuth stays the selected value for auth method, even though it is no longer available.

Expected result: The auth method defaults back to an available method.

Priority: -- → P1
Status: NEW → ASSIGNED
Attachment #9596542 - Attachment description: WIP: Bug 2044386 - Account Hub Manual Config: Update Auth option when OAuth selected but should be hidden. → Bug 2044386 - Account Hub Manual Config: Update Auth option when OAuth selected but should be hidden. r=#thunderbird-reviewers
Target Milestone: --- → 153 Branch

Pushed by corey@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/558dedb15fac
Account Hub Manual Config: Update Auth option when OAuth selected but should be hidden. r=freaktechnik

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: