Closed Bug 2044507 Opened 3 months ago Closed 3 months ago

Add new toggle to remove logo/wordmark

Categories

(Firefox :: Settings UI, enhancement)

enhancement

Tracking

()

VERIFIED FIXED
153 Branch
Tracking Status
firefox152 --- verified
firefox153 --- verified

People

(Reporter: nina-py, Assigned: nina-py)

References

Details

Attachments

(2 files)

Add a "Firefox logo" toggle to the Firefox Home section of about:preferences#home. The toggle controls the browser.newtabpage.activity-stream.hideLogo pref added in bug 2041708 and lets users hide the Firefox logo on New Tab.

Design

Figma frame — refer to this for positioning. Final copy is "Firefox logo" (with "Firefox" as a brand reference), not "Logo" as shown in the mock.

Adds a "Firefox logo" toggle to the Firefox Home section in about:preferences#home,
letting users hide the logo on New Tab.

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: Product managers would very much like to see this in 152 alongside with other settings as users are switched to the redesigned settings.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: no
  • Needs manual QE testing?: yes
  • Steps to reproduce for manual QE testing: Please see the test plan in the patch.
  • Risk associated with taking this patch: low
  • Explanation of risk level: Minor mechanical changes to existing code that works well - adding a yet another toggle on a page full of similar toggles. Fully covered by updated tests.
  • String changes made/needed?: There is one new string being added but we were lucky to find translations for it elsewhere and added a migration to this patch.
  • Is Android affected?: no
Attachment #9592905 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Adds a "Firefox logo" toggle to the Firefox Home section in about:preferences#home,
letting users hide the logo on New Tab.

Original Revision: https://phabricator.services.mozilla.com/D304314

Blocks: 2039925
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Flags: in-testsuite+
Attachment #9592905 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triage-done-c153/b152]
QA Whiteboard: [qa-triage-done-c153/b152] → [uplift][qa-ver-needed-c153/b152]

Hi Nina Pypchenko! I'm not seeing the Firefox logo when the toggle is enabled in about:preferences#home with latest Beta 152.0b8. I tested on Win 11 and macOS 26. Can you please take a look?

On latest Nightly 153.0a1, I can confirm that the Firefox logo is displayed as expected and the toggle correctly works as per test plan.

Flags: needinfo?(npypchenko)

Hi Nina Pypchenko! I'm not seeing the Firefox logo when the toggle is enabled in about:preferences#home with latest Beta 152.0b8. I tested on Win 11 and macOS 26. Can you please take a look?

I can confirm on macOS 26 that the toggle does not work at all in Firefox 152. For me, it's the opposite case: The logo is always visible, no matter how I set the toggle.

Blocks: 2048307
Duplicate of this bug: 2041299

Hi Sören, Ciprian, there were two parts to this feature update - the settings page update in this bug and the New Tab page update in https://bugzilla.mozilla.org/show_bug.cgi?id=2041708. The patch for this bug was uplifted to 152 because we couldn't trainhop the new string but for #2041708 it wasn't deemed necessary - it would have been included in a trainhop targeting 151+ a few weeks ago. Can you confirm this feature still doesn't work even with the latest New Tab XPI included?

Flags: needinfo?(npypchenko) → needinfo?(soeren.hentzschel)

How do I check if the latest XPI is included? I tested Firefox 152 again, and it still doesn't work.

Flags: needinfo?(soeren.hentzschel)

I've just downloaded Firefox 152 (I normally use FF Nightly) and I see that the current version is 152.0.1. On this version, I see the logo toggle at the bottom of about:settings#home and the toggle works for me to enable and disable the logo on the New Tab page.

Ciprian, could you double-check on the release version?

Flags: needinfo?(cgeorgiu)

It still doesn't work for me in Firefox 152.0.1. Could it have something to do with the fact that I'm using a German build? Because bug 2047698 describes another feature that's supposed to be delivered via trainhop and also doesn't seem to work in a German build.

Duplicate of this bug: 1973850

(In reply to Nina Pypchenko [:nina-py] from comment #12)

I've just downloaded Firefox 152 (I normally use FF Nightly) and I see that the current version is 152.0.1. On this version, I see the logo toggle at the bottom of about:settings#home and the toggle works for me to enable and disable the logo on the New Tab page.

Ciprian, could you double-check on the release version?

I can see the Firefox logo on Beta 153.0b5 and Release 152.0.3 if I switch the "browser.search.region" pref from "RO" to "US". Could you please confirm if that's expected, Nina?

Flags: needinfo?(cgeorgiu) → needinfo?(npypchenko)
Blocks: 2051807

I'll go ahead and assume the above is correct and close this bug as verified fixed.

Status: RESOLVED → VERIFIED
QA Whiteboard: [uplift][qa-ver-needed-c153/b152] → [uplift][qa-ver-done-c153/b152]
Flags: qe-verify+
Flags: needinfo?(npypchenko)
No longer blocks: 2051807
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: