204525 - Help button in Cookie Manager does not call up help popup

Status: VERIFIED DUPLICATE of bug 205176

(Firefox :: General, defect)

Description

[Pham]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030504 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030504 Mozilla Firebird/0.6

It has a help button which leads to nothing. 

It also has a close button, which is useless, but some stupid people might need
it, fearing they won't be able to do it as fast with the close in the titlebar,
but I'll let others decide...

Removing Close would be good also because it would make it consistent with Page
Info.

consistent with guy who lft Mozilla because it was too stupid.
http://mpt.phrasewise.com/stories/storyReader$4

Reproducible: Always

Steps to Reproduce:
1. Go to Options>Privacy>Cookies>View Cookies
2.
3.

Actual Results:  
See Help, which does nothing, and see Close, which is also useless(let
developers decide)

Expected Results:  
Remove Help, and ?maybe Close?

Comment 1

[Pham]

IS this preferences?

Comment 2

[Pham]

And I'm also against Close because it's redundant

Comment 3

[David P James]

Close is not ideal, but equating the Cookie Manager with Page Info is erroneous
as well - things can be changed in the CM whereas they can't be changed in Page
Info. If Close is removed, then it would have to be replaced with OK & Cancel
buttons.

The Help button is to accomodate a future help pop-up I believe and therefore
this bug is probably INVALID.

David?

Comment 4

[Pham]

"Help" button shouldn't be here now, since they're is no "about cookies popup"
now and maybe people will just repeatedly click on that button waiting for
something to come up and get frustrated. 

It should be removed now until the "about cookies popup" you're talking about
arrives.

>>>The Help button is to accomodate a future help pop-up

Where did you get that?

Comment 5

[David Tenser [:djst]]

I don't know really. Since it's not used, maybe it should be removed.

Comment 6

[Simon Paquet [:sipaq]]

I agree with Pham here. Unused buttons should be removed, because they can
confuse inexperienced users. The same goes to bug 204526.

Comment 7

[Pham]

>>If Close is removed, then it would have to be replaced with OK & Cancel
buttons.

Why would it need a "confirm"(OK) and "never mind"(Cancel button if it didn't
have one before?

Comment 8

[David P James]

Well just think for a moment what the CM is - you can remove a cookie (or all)
in it. Suppose a user does just that. Then how do they "get out" of the dialog?
Sure, they could press the 'X' button, but the perception would be that that
will simply exit the dialog without committing the change. Having a Close button
is bad UI, leaving nothing is even worse. The CM is not simply an info pop-up
and it cannot be treated as such.

>>The Help button is to accomodate a future help pop-up
>
>Where did you get that?

I did say "I believe" following that phrase... it only makes sense that that's
the reason it is there - it was clearly put there for some reason, and, in fact,
just checking with Mozilla, there is such a help pop-up. So this is really a bug
about the fact that the button is not doing what it should be doing.

-->Changing summary to reflect that fact and confirming

Comment 9

[David P James]

This is odd... using the pre-compiled Linux binaries, I'm seeing this bug and
bug 204526. But using a Linux build that I built from CVS, I'm getting the Help
pop-up that one would expect to get. I don't think that's enough to alter the
status of this bug, but it is rather intriguing.

Comment 10

[Pham]

>>Well just think for a moment what the CM is - you can remove a cookie (or all)
in it. Suppose a user does just that. Then how do they "get out" of the dialog?
Sure, they could press the 'X' button, but the perception would be that that
will simply exit the dialog without committing the change. 

That's odd because if I clear History, and then click cancel on the bottom, it
doesn't return History

Comment 11

[Pham]

Ok/Cancel debate

That's strange because I never remembered an app that had a delete function and
an OK/Cancel button at the same time.

Example:IE Favorites Organizer, Firebird Bookmarks Manager(has undo,redo), all
mail apps,etc

All those things don't have an OK/Cancel near the bottom so that I can confirm
that I deleted them or cancel all my delete actions. They just delete at that
moment.

Comment 12

[Pham]

IS this PC only?

Comment 13

[David P James]

This bug, bug 204526 and bug 205176 are all the result of the following
build-time config option:

ac_add_options
--enable-extensions=default,-inspector,-irc,-venkman,-content-packs,-help

Here, the important one is -help. For awhile I had been using a different set of
config options, including without a -help (which should be read as "less help"
or "minus help"). Remove the '-' or the '-help' altogether and it builds with
the Help extension.

Comment 14

[David P James]

Blake just changed the summary of bug 205176, though he probably should have
changed the summary of this one instead since it has more info. At any rate,
this bug is now a dupe that bug.

*** This bug has been marked as a duplicate of 205176 ***

Comment 15

[Simon Paquet [:sipaq]]

Mass-verifying. Sorry for bugspam.