2046307 - Trust panel doesn't get focus when opened

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[James Teh [:Jamie]]

STR:

1. Open https://www.mozilla.com/
2. Focus the address bar with the keyboard; e.g. with alt+d or control+l.
3. Shift+tab to the search engine selector.
4. Right arrow to the "View site information" button (#trust-icon-container).
5. Press space to activate it.
   • Expected: Focus should move inside the dialog.
   • Actual: Focus remains on the trigger button.

This is particularly problematic for screen reader users because when they activate the button, it appears as if nothing happens at all. Dialogs need to get focus in order for screen readers to report them.

Ideally, the panel should get focus regardless of what activated it, since some users might activate this other than by using the keyboard. However, there has been some contention in the past with regard to focusing panels when opened with the mouse. If it absolutely isn't possible to focus the panel in all cases because it breaks some user functionality, it would be acceptable to focus it only when triggered by the keyboard.

This is a borderline access s2 because a screen reader user won't know that happened, so it seems like this is just inaccessible. However, I'm triaging it s3 because there is a trivial workaround: you can press tab, and many users will probably try this due to the prevalence of accessibility failures in the wild.

9:40.72 INFO: Last good revision: 73e5ba0265ca720b4c6176c393b1463d1597b0e2
9:40.72 INFO: First bad revision: 31298ba1737e850dcf67963349d8168198c5b458
9:40.72 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=73e5ba0265ca720b4c6176c393b1463d1597b0e2&tochange=31298ba1737e850dcf67963349d8168198c5b458

This implicates bug 1988726. I'm fairly sure this exact same bug was fixed for the old site identity panel in the past and I'm fairly sure it also had a test, but I don't have the bug number offhand.

Comment 1

[James Teh [:Jamie]]

Hmm. I'm not sure if this belongs in Address Bar or Protections UI. The regressing bug 1988726 was filed in Address Bar, but its meta bug 1964725 was filed in Protections UI. 😕

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1988726

:daleharvey, since you are the author of the regressor, bug 1988726, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Dale Harvey (:daleharvey)]

Cheers we are using Protections UI for trustpanel bugs, will take a look to see if I can find the matching identity-popup bug

Comment 4

[James Teh [:Jamie]]

This has evolved over the years. See bug 1335018, bug 1343210, bug 1506503. The test for this is browser/base/content/test/siteIdentity/browser_identityPopup_focus.js. I guess this test doesn't run for the new panel?

Comment 5

[Dale Harvey (:daleharvey)]

Attachment: Bug 2046307 - Focus trustpanel when opened via keyboard.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:emz, could you have a look please?

For more information, please visit BugBot documentation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/207f17989b87
https://hg.mozilla.org/integration/autoland/rev/15f99a279f76
Focus trustpanel when opened via keyboard. r=urlbar-reviewers,Jamie,dao

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/15f99a279f76

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daleharvey, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox153 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Dale Harvey (:daleharvey)]

It took a while for this to be reported and it has a workaround so I think it can ride the trains

Comment 11

[Ryan VanderMeulen (PTO, back July 27)]

Does 153 being our next ESR release impact that assessment?