Update open tabs sidebar panel shortcut and make it available in the
Categories
(Firefox :: Sidebar, enhancement)
Tracking
()
People
(Reporter: asafko, Assigned: dr.seed.lu)
References
Details
Attachments
(1 file, 2 external files)
|
356.33 KB,
image/png
|
Details |
Hi folks,
Following the review of potential conflict with extensions' shortcuts, we decided to pick this combination for the open tabs sidebar panel:
- Ctrl + U for macOS
- Ctrl + Alt + U for Linux / Windows
The reasoning for change:
- pretty much every available three-stroke combination is used by one extension or another, so we'll cause conflict no matter what we pick,
- we need to reduce the impact of the conflict, so as few users as possible are impacted and need to change the shortcut in about:keyboard.
- our original shortcut combo conflicted with Bitwarden extension shortcut that has about 1M potentially impacted users. The impacted number of users for the new combination would be under ~2,000 daily users.
Let's please also make the shortcut available in about:keyboard, so users who do have the conflicting extensions installed can change this shortcut there.
Seed, thank you for bearing with the change, we've now introduced the AMO extensions shortcut review into the keyboard shortcut selection process.
Updated•5 months ago
|
The previous Ctrl+Shift+L shortcut clashed with Bitwarden's autofill
shortcut, and Bitwarden has around 1M users that could have been hit
by this.
After the AMO extension shortcut review, the new shortcuts
are Ctrl+U on macOS and Ctrl+Alt+U on Windows and Linux.
This keeps the conflict impact under about 2,000 daily users.
For the implementation I followed the same pattern that
viewGenaiChatSidebarKb already uses in browser-sets.inc.xhtml, where
the right modifiers get picked at build time based on the platform.
The browserSets.ftl entry moves from .key = L to .key = U.
The shortcut still appears in about:keyboard automatically through
the menubar menuitem setup I added in bug 2042921, so users with a
conflicting extension can rebind it from there.
Comment 5•5 months ago
|
||
Backed out for causing mochtiest failures @test_no_errors_clean_profile.py.
Comment 6•5 months ago
|
||
The fix for the test failure would be to add an entry here under known_errors: https://searchfox.org/firefox-main/source/browser/components/tests/marionette/test_no_errors_clean_profile.py#19
Something like:
{
# Triggered as soon as anything tries to use shortcut keys.
# Bug 1936426 to reconsider warning as we want ctrl-alt-u for open tabs.
"message": "viewOpenTabsSidebarKb",
},
Thanks Kelly.
I added the viewOpenTabsSidebarKb entry to known_errors in test_no_errors_clean_profile.py, following the same format as the existing viewGenaiChatSidebarKb entry.
The fix is now on D306038.
I ran the marionette test locally and it passed.
Updated•5 months ago
|
Comment 9•5 months ago
|
||
| bugherder | ||
Comment 11•5 months ago
|
||
The previous Ctrl+Shift+L shortcut clashed with Bitwarden's autofill
shortcut, and Bitwarden has around 1M users that could have been hit
by this.
After the AMO extension shortcut review, the new shortcuts
are Ctrl+U on macOS and Ctrl+Alt+U on Windows and Linux.
This keeps the conflict impact under about 2,000 daily users.
For the implementation I followed the same pattern that
viewGenaiChatSidebarKb already uses in browser-sets.inc.xhtml, where
the right modifiers get picked at build time based on the platform.
The browserSets.ftl entry moves from .key = L to .key = U.
The shortcut still appears in about:keyboard automatically through
the menubar menuitem setup I added in bug 2042921, so users with a
conflicting extension can rebind it from there.
Adds viewOpenTabsSidebarKb to known_errors in test_no_errors_clean_profile.py
to prevent the same backout that happened on the first land attempt.
Original Revision: https://phabricator.services.mozilla.com/D306038
Updated•5 months ago
|
Comment 12•5 months ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined/Reason for urgency: Users using popular extension Bitwarden will have trouble using keyboard shortcut for filling in a saved login
- Code covered by automated testing?: yes
- Fix verified in Nightly?: yes
- Needs manual QE testing?: yes
- Steps to reproduce for manual QE testing: Ensure Cmd/Ctrl+Shift+L now works for autofilling a saved login using Bitwarden. The open tabs sidebar panel shortcut has been updated to Ctrl+Alt+U (Ctrl+U on macOS).
- Risk associated with taking this patch: low
- Explanation of risk level: Changing a keyboard shortcut to prevent issues with Bitwarden extension shortcut
- String changes made/needed?: open-tabs-sidebar-shortcut is being changed to open-tabs-sidebar-shortcut2. The key attribute is being changed from .key = L to .key = U
- Is Android affected?: no
| Assignee | ||
Comment 13•5 months ago
|
||
Thank you Kelly for handling the uplift.
Updated•5 months ago
|
Comment 14•5 months ago
|
||
Hello! I can confirm the issue is fixed with firefox 153.0b1 on MacOS 15 and Ubuntu 24.04
Updated•5 months ago
|
Updated•5 months ago
|
Comment 15•5 months ago
|
||
| uplift | ||
Description
•