Closed Bug 2046497 Opened 5 months ago Closed 5 months ago

Update open tabs sidebar panel shortcut and make it available in the

Categories

(Firefox :: Sidebar, enhancement)

enhancement

Tracking

()

VERIFIED FIXED
154 Branch
Tracking Status
firefox153 --- fixed
firefox154 --- verified

People

(Reporter: asafko, Assigned: dr.seed.lu)

References

Details

Attachments

(1 file, 2 external files)

Hi folks,
Following the review of potential conflict with extensions' shortcuts, we decided to pick this combination for the open tabs sidebar panel:

  • Ctrl + U for macOS
  • Ctrl + Alt + U for Linux / Windows

The reasoning for change:

  • pretty much every available three-stroke combination is used by one extension or another, so we'll cause conflict no matter what we pick,
  • we need to reduce the impact of the conflict, so as few users as possible are impacted and need to change the shortcut in about:keyboard.
  • our original shortcut combo conflicted with Bitwarden extension shortcut that has about 1M potentially impacted users. The impacted number of users for the new combination would be under ~2,000 daily users.

Let's please also make the shortcut available in about:keyboard, so users who do have the conflicting extensions installed can change this shortcut there.

Seed, thank you for bearing with the change, we've now introduced the AMO extensions shortcut review into the keyboard shortcut selection process.

Flags: needinfo?(dr.seed.lu)
Assignee: nobody → dr.seed.lu
Status: NEW → ASSIGNED

The previous Ctrl+Shift+L shortcut clashed with Bitwarden's autofill
shortcut, and Bitwarden has around 1M users that could have been hit
by this.

After the AMO extension shortcut review, the new shortcuts
are Ctrl+U on macOS and Ctrl+Alt+U on Windows and Linux.

This keeps the conflict impact under about 2,000 daily users.

For the implementation I followed the same pattern that
viewGenaiChatSidebarKb already uses in browser-sets.inc.xhtml, where
the right modifiers get picked at build time based on the platform.
The browserSets.ftl entry moves from .key = L to .key = U.

The shortcut still appears in about:keyboard automatically through
the menubar menuitem setup I added in bug 2042921, so users with a
conflicting extension can rebind it from there.

Done.

Thank you.

Flags: needinfo?(dr.seed.lu)
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/310215e2aba3 https://hg.mozilla.org/integration/autoland/rev/91e8896a3f79 Update open tabs sidebar panel shortcut to Ctrl+Alt+U (Ctrl+U on macOS) r=kcochrane,nsharpley,fluent-reviewers,bolsson
Pushed by agoloman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/c35275918fd3 https://hg.mozilla.org/integration/autoland/rev/62e9135d71f8 Revert "Bug 2046497 - Update open tabs sidebar panel shortcut to Ctrl+Alt+U (Ctrl+U on macOS) r=kcochrane,nsharpley,fluent-reviewers,bolsson" for causing mochtiest failures @test_no_errors_clean_profile.py.

Backed out for causing mochtiest failures @test_no_errors_clean_profile.py.

Flags: needinfo?(dr.seed.lu)

The fix for the test failure would be to add an entry here under known_errors: https://searchfox.org/firefox-main/source/browser/components/tests/marionette/test_no_errors_clean_profile.py#19

Something like:

    {
        # Triggered as soon as anything tries to use shortcut keys.
        # Bug 1936426 to reconsider warning as we want ctrl-alt-u for open tabs.
        "message": "viewOpenTabsSidebarKb",
    },

Thanks Kelly.
I added the viewOpenTabsSidebarKb entry to known_errors in test_no_errors_clean_profile.py, following the same format as the existing viewGenaiChatSidebarKb entry.
The fix is now on D306038.
I ran the marionette test locally and it passed.

Flags: needinfo?(dr.seed.lu) → needinfo?(kcochrane)
Flags: needinfo?(kcochrane)
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8c3eafb9e94c https://hg.mozilla.org/integration/autoland/rev/c67af08f31ff Update open tabs sidebar panel shortcut to Ctrl+Alt+U (Ctrl+U on macOS) r=kcochrane,nsharpley,fluent-reviewers,bolsson
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch

Should we uplift to 153 beta? Thanks

Flags: needinfo?(dr.seed.lu)

The previous Ctrl+Shift+L shortcut clashed with Bitwarden's autofill
shortcut, and Bitwarden has around 1M users that could have been hit
by this.

After the AMO extension shortcut review, the new shortcuts
are Ctrl+U on macOS and Ctrl+Alt+U on Windows and Linux.

This keeps the conflict impact under about 2,000 daily users.

For the implementation I followed the same pattern that
viewGenaiChatSidebarKb already uses in browser-sets.inc.xhtml, where
the right modifiers get picked at build time based on the platform.
The browserSets.ftl entry moves from .key = L to .key = U.

The shortcut still appears in about:keyboard automatically through
the menubar menuitem setup I added in bug 2042921, so users with a
conflicting extension can rebind it from there.

Adds viewOpenTabsSidebarKb to known_errors in test_no_errors_clean_profile.py
to prevent the same backout that happened on the first land attempt.

Original Revision: https://phabricator.services.mozilla.com/D306038

Attachment #9598060 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: Users using popular extension Bitwarden will have trouble using keyboard shortcut for filling in a saved login
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: yes
  • Steps to reproduce for manual QE testing: Ensure Cmd/Ctrl+Shift+L now works for autofilling a saved login using Bitwarden. The open tabs sidebar panel shortcut has been updated to Ctrl+Alt+U (Ctrl+U on macOS).
  • Risk associated with taking this patch: low
  • Explanation of risk level: Changing a keyboard shortcut to prevent issues with Bitwarden extension shortcut
  • String changes made/needed?: open-tabs-sidebar-shortcut is being changed to open-tabs-sidebar-shortcut2. The key attribute is being changed from .key = L to .key = U
  • Is Android affected?: no
Flags: qe-verify+

Thank you Kelly for handling the uplift.

Flags: needinfo?(dr.seed.lu)
QA Whiteboard: [uplift][qa-ver-needed-c154/b153]

Hello! I can confirm the issue is fixed with firefox 153.0b1 on MacOS 15 and Ubuntu 24.04

Status: RESOLVED → VERIFIED
QA Whiteboard: [uplift][qa-ver-needed-c154/b153] → [uplift][qa-ver-done-c154/b153]
Flags: qe-verify+
QA Contact: snegritas
Attachment #9598060 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: