Closed Bug 2046848 Opened 2 months ago Closed 1 month ago

Add "Create a New Profile" menu item to account menu for Nova

Categories

(Firefox :: Menus, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
154 Branch
Tracking Status
firefox154 --- verified

People

(Reporter: nsharpley, Assigned: nsharpley, NeedInfo)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Whiteboard: [fidefe-nova])

Attachments

(3 files)

Spec: https://www.figma.com/design/XT0eDYh4RtbMNWaYQi0efM/Chrome-Sidebar-UX-Specifications--Sprint-1-?node-id=3796-142219&p=f&m=dev

  • add "Create a New Profile" menu item to accounts menu when not signed in or one (original) profile only
  • add "Create a New Profile" panel with links to copy, manage, create and "What Are Profiles?"
  • add "Create a New Profile" menu item to accounts menu when not signed in or one (original) profile only
  • add "Create a New Profile" panel with links to copy, manage, create and "What Are Profiles?"
Blocks: 2053794
Pushed by nsharpley@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/0b97cbced9ae https://hg.mozilla.org/integration/autoland/rev/9552a6e3ee3d Add "Create a New Profile" menu item and panel to account menu r=desktop-theme-reviewers,jhirsch,fluent-reviewers,bolsson
Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d2f9177c6147 https://hg.mozilla.org/integration/autoland/rev/bef10c3b5047 Revert "Bug 2046848, Bug 2046787 - Add "Create a New Profile" menu item and panel to account menu r=desktop-theme-reviewers,jhirsch,fluent-reviewers,bolsson" for causing stylelint failures

Backed out for causing stylelint failures
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/themes/shared/customizableui/panelUI-shared.css:1141:3 | 224px should use a size or icon-size design token. (stylelint-plugin-mozilla/use-design-tokens)

Flags: needinfo?(nsharpley)
Flags: needinfo?(nsharpley)
Pushed by nsharpley@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d975cd7c3716 https://hg.mozilla.org/integration/autoland/rev/2cd2ce6f68e7 Add "Create a New Profile" menu item and panel to account menu r=desktop-theme-reviewers,jhirsch,fluent-reviewers,bolsson
Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b753c4b889a3 https://hg.mozilla.org/integration/autoland/rev/04d70f48a94f Revert "Bug 2046848, Bug 2046787 - Add "Create a New Profile" menu item and panel to account menu r=desktop-theme-reviewers,jhirsch,fluent-reviewers,bolsson" for causing bc failures at sentence_case_strings.js

Backed out for causing bc failures at sentence_case_strings.js
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_sentence_case_strings.js | test_sentence_case_appmenu - Create a New Profile for appMenu-create-profile-button should have sentence casing. - false == true

Flags: needinfo?(nsharpley)
Pushed by nsharpley@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/39b73ebee0a5 https://hg.mozilla.org/integration/autoland/rev/cf60b446637f Add "Create a New Profile" menu item and panel to account menu r=desktop-theme-reviewers,jhirsch,fluent-reviewers,bolsson
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch

Verified as fixed using the latest Nightly 154.0a1 on Windows 11, Ubuntu 24.04, and macOS 26.4. The Create new profile menu item and panel are now available in both the Account menu and the App menu.

@Nikki, I did notice a couple of inconsistencies with the Create new profile menu item in the App menu. In the Figma specs, there is no icon on the left, and the panel does not include the Manage Profiles option. Is this just a discrepancy in the Figma design? - please see the attached screenshoot.

Also, I noticed that after clicking Manage Profiles, the Create new profile menu item changes to Original profile. Is this the expected behavior in this case?

QA Whiteboard: [qa-ver-needed-c154/b153]
QA Contact: sbadau
See Also: → 2055814, 2055783
QA Whiteboard: [qa-ver-needed-c154/b153] → [qa-ver-needed-c155/b154]
Flags: qe-verify+
Regressions: 2055783

Marking this as Verified based on Comment 10 and the fact that Bug 2055860 and Bug 2061350 were filed to track the issues mentioned there.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-ver-needed-c155/b154] → [qa-ver-done-c155/b154]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: