Closed Bug 2046787 Opened 2 months ago Closed 1 month ago

Update profiles section of account menu with Nova changes

Categories

(Firefox :: Menus, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
154 Branch
Tracking Status
firefox154 --- verified
firefox155 --- verified

People

(Reporter: nsharpley, Assigned: nsharpley, NeedInfo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-nova])

Attachments

(2 files)

Spec: https://www.figma.com/design/XT0eDYh4RtbMNWaYQi0efM/Chrome-Sidebar-UX-Specifications--Sprint-1-?node-id=24530-26275&m=dev

  • change order of original profile menu items
  • move edit options from icon to menu item
  • display up to 3 other profiles under profiles section in accounts menu
Attachment #9596674 - Attachment description: WIP: Bug 2046787 - Update profiles section of account menu with Nova changes → Bug 2046787 - Update profiles section of account menu with Nova changes r=sthompson
Depends on: 2052002
Pushed by nsharpley@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/cba7c8a0b9fd https://hg.mozilla.org/integration/autoland/rev/9bf69fc4b5ae Update profiles section of account menu with Nova changes r=sthompson,fluent-reviewers,desktop-theme-reviewers,niklas,bolsson
Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/609d3108ca9e https://hg.mozilla.org/integration/autoland/rev/2b80db7595e3 Revert "Bug 2046787 - Update profiles section of account menu with Nova changes r=sthompson,fluent-reviewers,desktop-theme-reviewers,niklas,bolsson" for causing failures at fxa_menu_profiles.js

Backed out for causing failures bc and TV failures at fxa_menu_profiles.js
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | browser/components/profiles/tests/browser/browser_fxa_menu_profiles.js | test_fxa_menu_shows_up_to_three_profiles - Uncaught exception in test - TypeError: BrowserTestUtils.waitForCondition is not a function

Flags: needinfo?(nsharpley)
Pushed by nsharpley@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/879d15dcaf97 https://hg.mozilla.org/integration/autoland/rev/9f8c7db0a209 Update profiles section of account menu with Nova changes r=sthompson,fluent-reviewers,desktop-theme-reviewers,niklas,bolsson
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch

While trying to verify this, I've noticed that the Profiles section is no longer displayed in either the Account menu or the App menu.

@Nikki, is this expected?
Please see also Bug 2053794.

Regressions: 2053794
Flags: needinfo?(nsharpley)
Pushed by archaeopteryx@coole-files.de: https://github.com/mozilla-firefox/firefox/commit/2ca36d3181a5 https://hg.mozilla.org/integration/autoland/rev/40cc20f33c7c Revert "Bug 2046787 - Update profiles section of account menu with Nova changes r=sthompson,fluent-reviewers,desktop-theme-reviewers,niklas,bolsson" for preventing creation of selectable profiles (bug 2053794)
Status: RESOLVED → REOPENED
Flags: needinfo?(nsharpley)
Resolution: FIXED → ---
Target Milestone: 154 Branch → ---
Pushed by archaeopteryx@coole-files.de: https://github.com/mozilla-firefox/firefox/commit/6eacd7a0b7f8 https://hg.mozilla.org/integration/autoland/rev/a5cf15ee6538 Revert "Bug 2046787 - Update profiles section of account menu with Nova changes r=sthompson,fluent-reviewers,desktop-theme-reviewers,niklas,bolsson" for preventing creation of selectable profiles (bug 2053794): fix linting issue
Pushed by nsharpley@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/6a3df308ff27 https://hg.mozilla.org/integration/autoland/rev/d397a87d56d5 Update profiles section of account menu with Nova changes r=sthompson,fluent-reviewers,desktop-theme-reviewers,niklas,bolsson
Pushed by nsharpley@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/118bbd5a09a3 https://hg.mozilla.org/integration/autoland/rev/42edfa420ab0 Update profiles section of account menu with Nova changes r=sthompson,fluent-reviewers,desktop-theme-reviewers,niklas,bolsson
Pushed by nsharpley@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b0740426a456 https://hg.mozilla.org/integration/autoland/rev/096344bb31ad Update profiles section of account menu with Nova changes r=sthompson,fluent-reviewers,desktop-theme-reviewers,niklas,bolsson
Status: REOPENED → RESOLVED
Closed: 2 months ago1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
QA Whiteboard: [qa-triage-done-c155/b154][qa-ver-needed-c155/b154]
Flags: qe-verify+

Verified as fixe using Firefox 154.0b7 and the latest Nightly 155.0a1 on Ubuntu 24.04, macOS 26 and Windows 11 - the updates mentioned in the description have been made.

QA Whiteboard: [qa-triage-done-c155/b154][qa-ver-needed-c155/b154] → [qa-triage-done-c155/b154][qa-ver-done-c155/b154]
Flags: qe-verify+
QA Contact: sbadau
Regressions: 2067734
Regressions: 2068917
No longer regressions: 2068917
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: