2047232 - Update PBM newtab promo for Nova

Status: VERIFIED FIXED

(Firefox :: Private Browsing, enhancement, P1)

Description

[Emma Zühlcke [:emz]]

Bug 2033037 updated newtab for Nova but missed the promo slot. This bug is for updating the promo to the new design.

Comment 1

[Emma Zühlcke [:emz]]

Attachment: Bug 2047232 - Use moz-promo for the nova private browsing newtab promo. r=timhuang!

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 2047232 - Render the nova private browsing promo CTA as a button when promoLinkType is button. r=hjones!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6e7cd6aa6606
https://hg.mozilla.org/integration/autoland/rev/ade7ec97122a
Use moz-promo for the nova private browsing newtab promo. r=timhuang,desktop-theme-reviewers,hjones
https://github.com/mozilla-firefox/firefox/commit/fb36283528d3
https://hg.mozilla.org/integration/autoland/rev/da8c45104f93
Render the nova private browsing promo CTA as a button when promoLinkType is button. r=hjones

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ade7ec97122a
https://hg.mozilla.org/mozilla-central/rev/da8c45104f93

Comment 5

[Raluca Popovici, Desktop QA]

None of the banners are shown in Ubuntu 24 using Nightly 154.0a1(2026-06-25):
PB_FOCUS_PROMO
PB_NEWTAB_VPN_PROMO
PB_PIN_PROMO
PB_NEWTAB_FOCUS_PROMO
PB_NEWTAB_KLAR_PROMO
PB_NEWTAB_KLAR_PROMO_DE
PB_NEWTAB_PIN_PROMO
So I will reopen this bug.
Note: The issue is fixed only in Windows 11 and macOS 13.

Comment 6

[Emma Zühlcke [:emz]]

Could you please file a new bug instead?

Comment 7

[Emma Zühlcke [:emz]]

(In reply to Raluca Popovici, Desktop QA from comment #5)

None of the banners are shown in Ubuntu 24 using Nightly 154.0a1(2026-06-25):
PB_FOCUS_PROMO
PB_NEWTAB_VPN_PROMO
PB_PIN_PROMO
PB_NEWTAB_FOCUS_PROMO
PB_NEWTAB_KLAR_PROMO
PB_NEWTAB_KLAR_PROMO_DE
PB_NEWTAB_PIN_PROMO
So I will reopen this bug.
Note: The issue is fixed only in Windows 11 and macOS 13.

I've tested a few of these on Ubuntu 24.04 LTS via asrouter devtools and they show up fine in the latest Nightly version (2026-06-26). Can you check again? Perhaps your Nightly build on Ubuntu didn't include the changes?

Comment 8

[Raluca Popovici, Desktop QA]

I've tested again on Ubuntu 24.04.4 LTS via asrouter devtools in the latest Nightly version 154.0a1(2026-06-28) and all the PB banners are displayed.

Comment 9

[Emily McMinn :emcminn]

Hey folks, I've noticed while testing https://phabricator.services.mozilla.com/D310414#change-hD4pSWjXHGvV that the legacy promos are no longer showing, either naturally or when forced through devtools.

It's a little tricky to follow in the debugger, but what I think I've found is that when browser.nova.enabled is false, for some reason the default values in renderPromo are never getting updated with the message content, so promoEnabled is always false and the render bails. With Nova enabled, everything seems fine.

Any idea what might be happening here?

Comment 10

[Emma Zühlcke [:emz]]

I suspect it's Bug 2054149. Not a direct regression of this bug, but most likely Bug 2051196.