2047467 - Update vendored mp4parse-rust to b693c7e4a91d

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task)

Description

[Matthew Gregan [:kinetik]]

Bump the vendored mp4parse-rust revision in toolkit/library/rust/shared/Cargo.toml from 3d36cb1c1211 to c04924469873 (current mozilla/mp4parse-rust master), via mach vendor rust. This pulls in three upstream commits:

• ac4ed53f980f "Fix esds DSI parsing for truncated and duplicate DecSpecificInfo" -- fix for bug 2011644.
• 73423e14f24c "Tolerate nclx colr boxes missing the full_range_flag byte" -- fix for bug 2047239.
• c04924469873 "Make duplicate colr detection per colour_type in video sample entries".

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Bug 2047467 - Update mp4parse-rust to b693c7e4a91d. r?#media-playback-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e938d85c1001
https://hg.mozilla.org/integration/autoland/rev/21c08e41042f
Update mp4parse-rust to b693c7e4a91d. r=media-playback-reviewers,padenot

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/21c08e41042f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Can we uplift this to Beta and Release?

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Fixes a regression that broke MP4 media playback for files containing invalid colr boxes.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Simple fix, relaxing the strictness of colr box parsing to accept common "invalid" (per spec) variants that other MP4 parsers accept.
• String changes made/needed?: N/A
• Is Android affected?: yes

Comment 6

[Matthew Gregan [:kinetik]]

Attachment: Bug 2047467 - Update mp4parse-rust to b693c7e4a91d.

Original Revision: https://phabricator.services.mozilla.com/D306670

Comment 7

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: Fixes a regression that broke MP4 media playback for files containing invalid colr boxes.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Simple fix, relaxing the strictness of colr box parsing to accept common "invalid" (per spec) variants that other MP4 parsers accept.
• String changes made/needed?: N/A
• Is Android affected?: yes

Comment 8

[Matthew Gregan [:kinetik]]

Attachment: Bug 2047467 - Update mp4parse-rust to b693c7e4a91d.

Backport to release: updates vendored mp4parse-rust from fb7ed9ef straight to
b693c7e4. Because release was two revs behind, this necessarily bundles upstream
PR 450 (Bug 2044320 - r=media-playback-reviewers,kinetik) in addition to the
2047467 change. The resulting third_party/rust/mp4parse tree is byte-identical
to the trunk landing.

Original Revision: https://phabricator.services.mozilla.com/D306670

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/f8adab53235a
https://hg.mozilla.org/releases/mozilla-beta/rev/de0089425e7f

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/74d43dd31595
https://hg.mozilla.org/releases/mozilla-release/rev/107e7c1a470f

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Added to the 152.0.2 relnotes.