2047614 - Containers: introduce the 'add new container' feature in context menu

Status: RESOLVED FIXED

(Firefox :: Containers, task)

Description

[Andrea Marchesini [:baku]]

See the figma spec: https://www.figma.com/design/manq7LlXFPeIUvbhoBif8f/Containers?node-id=3796-142219&p=f&m=dev

Talking with Misha, we decided to anchor the "add new container" dialog to the Container url-bar pill.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 2047614 - Containers: introduce the 'add new container' feature in context menu

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c62815cc2358
https://hg.mozilla.org/integration/autoland/rev/15ea72eab186
Containers: introduce the 'add new container' feature in context menu r=desktop-theme-reviewers,tabbrowser-reviewers,tgiles,fluent-reviewers,bolsson,jsudiaman

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1a21987ef7c4
https://hg.mozilla.org/integration/autoland/rev/58f8c87a2a1f
Revert "Bug 2047614 - Containers: introduce the 'add new container' feature in context menu r=desktop-theme-reviewers,tabbrowser-reviewers,tgiles,fluent-reviewers,bolsson,jsudiaman" for causing failures at browser_containers_name_input.js.

Comment 4

[Atila Butkovits]

Backed out for causing failures at browser_containers_name_input.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/58f8c87a2a1f

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=15ea72eab18684e02c22a7d0b5df6f0379f933cf&selectedTaskRun=cKTqDoCLTOife_h-Lab-Hw.1

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=575700644&repo=autoland&task=BmAEMlRLRRyBe3QM6g78jg.0&lineNumber=3873
https://treeherder.mozilla.org/logviewer?job_id=575700587&repo=autoland&task=bW8fv4ypTzKk-WnZ5v0E2Q.0&lineNumber=4204

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fcc3fd9554ad
https://hg.mozilla.org/integration/autoland/rev/9941f91b3657
Containers: introduce the 'add new container' feature in context menu r=desktop-theme-reviewers,tabbrowser-reviewers,tgiles,fluent-reviewers,bolsson,jsudiaman

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/9941f91b3657