2062099 - "Add new container" context menu option does not work from Library window or old sidebar

Status: RESOLVED FIXED

(Firefox :: Containers, defect)

Description

[Sam Johnson]

When right-clicking a bookmark in the Library window, or in the old sidebar, and selecting Open in New Container Tab > Add new container, nothing happens. An error is logged to the console, however:

JavaScript error: chrome://browser/content/usercontext/ContainerCreationPanel.mjs, line 33: TypeError: can't access property "state", panel is null

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2047614

:baku, since you are the author of the regressor, bug 2047614, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 2062099 - "Add new container" context menu option does not work from Library window or old sidebar

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6aa30069a56f
https://hg.mozilla.org/integration/autoland/rev/782c7e4b669b
"Add new container" context menu option does not work from Library window or old sidebar r=places-reviewers,Standard8

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/782c7e4b669b

Comment 5

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:baku, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox155 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: A broken functionality in a context menu
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: The patch implements a different way to trigger existing functionalizes. Low risk
• String changes made/needed?: none
• Is Android affected?: no

Comment 7

[Andrea Marchesini [:baku]]

Attachment: Bug 2062099 - "Add new container" context menu option does not work from Library window or old sidebar

Original Revision: https://phabricator.services.mozilla.com/D317439

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/b84c380256a7
https://hg.mozilla.org/releases/mozilla-beta/rev/901b2fb3b08b