2047747 - [Google Lens] Move Google Lens control setting to "search settings" from "ai settings"

Status: RESOLVED FIXED

(Firefox for Android :: Search, task)

Comment 1

[[:harrisono]]

Attachment: Bug 2047747 - Move Google Lens integration on off setting to Search settings page

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/56021c5214f1
https://hg.mozilla.org/integration/autoland/rev/322b73a847e9
Move Google Lens integration on off setting to Search settings page r=android-reviewers,android-l10n-reviewers,parker,petru

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/322b73a847e9

Comment 4

[[:harrisono]]

Attachment: Bug 2047747 - Move Google Lens integration on off setting to Search settings page

Original Revision: https://phabricator.services.mozilla.com/D310681

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Setting is in wrong place, must be removed from "AI Controls" before launch in release 153
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Low level settings movement in screens, overall settings mechanisms remain the same.
• String changes made/needed?: renaming some strings to reflect their actual use location rather than "AI controls". No strings are changed.
• Is Android affected?: yes

Comment 6

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

This patch is I think changing string IDs, I don't know if it may cause l10n issues in the 153 UI worse than that bug that is being fixed. I think we need an l10n-driver to chime in.

Camila, what do you think?

Comment 7

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/7e33f0f826ce
https://hg.mozilla.org/releases/mozilla-beta/rev/182337c7bf06

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/b81d115c164b
https://hg.mozilla.org/releases/mozilla-beta/rev/e838658c28b3

Comment 9

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Backed out from beta as landing this patch conflicts with landing bug 2052999.
harrisono, it seems that the l10n linter errors are because you are adding here strings that you use in bug 2052999 but you didn't stack these 2 patches to land together. Morever, it seems that you are adding the same 2 strings in the 2 patches. Could you update your patches and stack your commits so as that they land together without merge conflicts for our last beta on Wednesday? Thanks

Comment 10

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Setting is in wrong place, must be removed from "AI Controls" before launch in release 153
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Low level settings movement in screens, overall settings mechanisms remain the same.
• String changes made/needed?: renaming some strings to reflect their actual use location rather than "AI controls". No strings are changed.
• Is Android affected?: yes

Comment 11

[[:harrisono]]

Attachment: Bug 2047747 - Move Google Lens integration on off setting to Search settings page

Original Revision: https://phabricator.services.mozilla.com/D310681

Comment 12

[Camila Pedraza [:parker]]

Okay from the L10N front with latest changes

Comment 13

[Camila Pedraza [:parker]]

Sorry. Accidentally removed the needinfo flag for harrisono with my comment. Re-adding flag here just in case.

Comment 14

[[:harrisono]]

ok I'll work on trying to get these patches in line

Comment 15

[Mira Lobontiu (Android QA)]

Attachment: Screenshot_20260714_103032_org.mozilla.fenix.jpg

Verified as fixed on the latest Firefox for Android Nightly 154.0a1 from 7/13 using a Pixel 6 (Android 17), and a Huawei Pura 70 (Android 12).
If the option is disabled, the Google Lens is replaced with the QR code icon.
When the option is enabled, the Google Lens icon is available.

Comment 16

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Comment on attachment 9606730 [details]
Bug 2047747 - Move Google Lens integration on off setting to Search settings page

This is too late for uplift now as we are building 153.0 today.

Comment 17

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Comment on attachment 9607269 [details]
Bug 2047747 - Move Google Lens integration on off setting to Search settings page

This is too late for uplift now as we are building 153.0 today.