2052999 - [Google Lens] Google Lens camera-overlay should say "Search" or mention Google Lens, to give the user some awareness of what's going to happen when they take or submit a photo

Status: RESOLVED FIXED

(Firefox for Android :: Search, defect)

Description

[Daniel Holbert [:dholbert]]

Steps to reproduce

1. Open a new tab and tap the address bar.
2. Tap the Google Lens photo at the right side.
3. Look at the camera UI that comes up.

Expected behavior

Some sort of indication about what's going to happen when I take a photo (or what will happen when I pick an existing image from my camera roll, if I follow that part of the flow instead)

Actual behavior

No indication about what's going to happen.

Device information

• Firefox version: 154.0a1
• Android device model: Pixel 10 Pro XL, Pixel 6a
• Android OS version: 17

Any additional information?

I think we're planning to add some sort of onboarding/messaging for this UI, which is great -- but I'm focusing this bug on what happens after the user has tapped through the onboardding (e.g. if they weren't paying attention or don't use the feature until much later and they've forgotten the onboarding). I think we need some sort of in-content indicator to give the user a clue that the photo will be submitted for a search operation, because otherwise users might be expecting a local-only QR-code scanner, or might not know what to expect, and end up feeling surprised/betrayed when they see their photo on a Google Search page (see scenarios in bug 2032573 for example).

For comparison/reference, in Chrome on Android's Google Lens integration, their camera overlay has a magnifying glass icon for the take-photo button, and there's a bar at the bottom with different actions that can be taken, with "Search" clearly selected. So they make it clear that the photo will be submitted to a search engine.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of current Firefox Nightly lens integration camera UI (no indicator about what will happen to photo)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of analogous UI in Chrome (several icons/labels saying "search" and mentioning Google Lens as the search destination)

Comment 3

[[:harrisono]]

Attachment: Bug 2052999 - Google Lens camera screen title for user clarity

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/90e19f70d081
https://hg.mozilla.org/integration/autoland/rev/79b3bf85bc2d
Google Lens camera screen title for user clarity r=android-reviewers,android-l10n-reviewers,sfamisa,parker

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/79b3bf85bc2d

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Users need this description for the release in order to know they are sending images to google versus just the original QR code scanner.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Adding a title to an existing screen. little code complexity risk.
• String changes made/needed?: Yes, one is "Google Lens" and the other is "QR Code".
• Is Android affected?: yes

Comment 7

[[:harrisono]]

Attachment: Bug 2052999 - Google Lens camera screen title for user clarity

Original Revision: https://phabricator.services.mozilla.com/D310931

Comment 8

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

harrisono, the patch failed to land on beta, could you rebase please? Thanks
Also, the linter errors from bug 2047747 seem to be caused by a dependency on this patch as the strings in bug 2047747 are used in this bug. Wasn't it supposed to land as a stack?

Comment 9

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Comment on attachment 9606683 [details]
Bug 2052999 - Google Lens camera screen title for user clarity

This is too late for uplift now as we are building 153.0 today.