2048293 - Sidebar panel should not have gaps and should have a rounded border radius when launcher is not shown

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[Jeremy Swinarton]

Attachment: Screenshot 2026-06-17 at 11.46.03 am.png

See Figma spec: https://www.figma.com/design/XT0eDYh4RtbMNWaYQi0efM/Chrome-Sidebar-UX-Specifications--Sprint-1-?node-id=9006-88201&m=dev

There is a gap between the sidebar launcher and panel in Nova mode (horizontal tabs only). According to the spec, this should be a single 1px line, not a gap.

Comment 1

[Eric Pang [:epang] UX]

noting that on vertical tabs it looks like the div line is 2px instead of 1px, so a smaller tweak for it

Comment 3

[Sarah Clements [:sclements] | PTO until Oct 12th]

Another note is that when the panel is shown without the launcher (select vertical tabs -> hide tabs and sidebar) we probably want the left-most corner of the panel to be rounded; currently its not. This will also become apparent with Kelly's patch to add a switcher (hide sidebar for horizontal tabs in bug 2047653) as the launcher won't be present at all.

Comment 4

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 2048293 - Fix gaps and unrounded left side corner in the sidebar panel. r?#sidebar-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8031aeb29495
https://hg.mozilla.org/integration/autoland/rev/794338fa173e
Fix gaps and unrounded left side corner in the sidebar panel. r=nsharpley

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/794338fa173e

Comment 7

[Simona Badau, Desktop Test Engineering]

Reproduced the initial issue on Firefox 154.0a1 (Build ID: 20260709205531).

Verified as fixed using Firefox 154.0b7 and the latest Nightly 155.0a1 on Windows 11, Ubuntu 24.04 and macOS 26 - a single 1px line is displayed between the Sidebar and Panel in Nova mode.