Closed Bug 2047653 Opened 2 months ago Closed 1 month ago

Explore the option to bring the dropdown panel selection to the new sidebar

Categories

(Firefox :: Sidebar, task, P1)

task

Tracking

()

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: asafko, Assigned: kcochrane)

References

(Regressed 1 open bug)

Details

(Whiteboard: [fidefe-sidebar])

Attachments

(2 files)

This is a ticket to explore the relative effort of bringing the following interaction to the sidebar.revamp = true:

  • Customize sidebar setting to hide the sidebar launcher in horizontal mode
  • dropdown selection of the panels from the panel header (including Customize sidebar panel, but without options to close sidebar and move it to the right)
Assignee: nobody → kcochrane
Whiteboard: [fidefe-sidebar]
Status: NEW → ASSIGNED

Kelly, Eric pointed out that chatbot panel already has a dropdown in the header.
We can potentially use this pattern, and in the chatbot panel put the panel list first, and the list of the chatbot providers second.

Attachment #9597527 - Attachment description: WIP: Bug 2047653 - Add a dropdown for switching sidebar panels when sidebar.revamp is true → Bug 2047653 - Add a dropdown for switching sidebar panels when sidebar.revamp is true
See Also: → 2046709
Severity: -- → S3
Priority: -- → P1
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ac27f370c97a https://hg.mozilla.org/integration/autoland/rev/8d7431b582d7 Add a dropdown for switching sidebar panels when sidebar.revamp is true r=fluent-reviewers,sclements,echa,bolsson,firefox-desktop-core-reviewers
Pushed by pstanciu@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/be3508952608 https://hg.mozilla.org/integration/autoland/rev/5c0a7e2fdf59 Revert "Bug 2047653 - Add a dropdown for switching sidebar panels when sidebar.revamp is true r=fluent-reviewers,sclements,echa,bolsson,firefox-desktop-core-reviewers" for causing mochitests failures @ browser_resize_sidebar.js
Flags: needinfo?(kcochrane)

Here's the behavior for the new setting that we propose:
Opening tools from launcher remains a default for all users. Horizontal tabs users can change the default, while vertical tabs users cannot.

Customize sidebar menu

  • Show new checkbox Open tools from sidebar between Vertical tabs and Move sidebar to the right checkboxes.
    **For horizontal tab users: **
  • Have the checkbox be pre-checked by default (this setting reflects that tools are placed in the launcher) and customizable.
  • If users uncheck it, turn on the dropdown navigation

For vertical tab users:

  • If a user checks the Vertical tabs checkbox, disable the Open tools from sidebar checkbox, while showing that it's checked.
Flags: needinfo?(kcochrane)
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/3c6b783b3a4a https://hg.mozilla.org/integration/autoland/rev/6d9c8c01dcbd Add a dropdown for switching sidebar panels when sidebar.revamp is true r=fluent-reviewers,sclements,echa,bolsson,firefox-desktop-core-reviewers
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
Regressions: 2052275
Blocks: 2052330
Regressions: 2052334
No longer blocks: 2052330
Regressions: 2052330
Regressions: 2052507
Regressions: 2052631

I'd like to request a backout on this due to all the regressions.

Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/94e2e3ed9e4e https://hg.mozilla.org/integration/autoland/rev/21dcb4fc9279 Revert "Bug 2047653 - Add a dropdown for switching sidebar panels when sidebar.revamp is true r=fluent-reviewers,sclements,echa,bolsson,firefox-desktop-core-reviewers" at dev request for causing Bug 2052631
Status: RESOLVED → REOPENED
Flags: needinfo?(kcochrane)
Resolution: FIXED → ---
Target Milestone: 154 Branch → ---
Flags: needinfo?(kcochrane)
Pushed by archaeopteryx@coole-files.de: https://github.com/mozilla-firefox/firefox/commit/83ce8146b825 https://hg.mozilla.org/integration/autoland/rev/53eb67835c2e Add a dropdown for switching sidebar panels when sidebar.revamp is true r=fluent-reviewers,sclements,echa,bolsson,firefox-desktop-core-reviewers https://github.com/mozilla-firefox/firefox/commit/17c4f3807eb0 https://hg.mozilla.org/integration/autoland/rev/f6ca012f57e3 Revert "Bug 2047653 - Add a dropdown for switching sidebar panels when sidebar.revamp is true r=fluent-reviewers,sclements,echa,bolsson,firefox-desktop-core-reviewers" for regressions
Attachment #9597527 - Attachment description: Bug 2047653 - Add a dropdown for switching sidebar panels when sidebar.revamp is true → Bug 2047653 - Add a dropdown for switching sidebar panels when sidebar.revamp is true r=fluent-reviewers,sclements,echa,bolsson,firefox-desktop-core-reviewers
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8fa8eed7989d https://hg.mozilla.org/integration/autoland/rev/652d128ec55a Add a dropdown for switching sidebar panels when sidebar.revamp is true r=fluent-reviewers,sclements,echa,bolsson,firefox-desktop-core-reviewers
Status: REOPENED → RESOLVED
Closed: 1 month ago1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
QA Whiteboard: [qa-triage-done-c155/b154][qa-ver-needed-c155/b154]
Flags: qe-verify+
Regressions: 2057968
Regressions: 2064638
No longer regressions: 2064638
Regressions: 2065431
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: