2048352 - Migrate code-review-bot to push to Github instead of Try

Status: REOPENED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Andrew Halberstadt [:ahal]]

Code review bot currently pushes changes to hg.mozilla.org/try. Since we're migrating over to Github we'll need it to push to Github instead (exact repository tbd).

Repo: https://github.com/mozilla/code-review

Fixing this will involve changes to at least the following places:

• A GitRepository class that implements a similar interface as the existing Mercurial one
• Add code to choose the correct repository class based on a repo type or similar
• A separate way to auth, probably just use the same store that we do for the Mercurial ssh key, except use a Github deploy key instead for the repo in question. Alternatively could use a Github App, but deploy key is easiest
• Skip Lando's git2hg API call
• Skip treestatus check
• Adjust Treeherder url (depending where we decide to push, we may need to add it to Treeherder first)

If we need a temporary repository to push to for testing purposes, we can use https://github.com/mozilla-releng/staging-firefox. Ping me if access and/or deploy key is needed here.

Comment 1

[Andrew Halberstadt [:ahal]]

We'll also want to update the Treeherder link in Phabricator to point to the new repo. Can worry about this later but just mentioning so we don't forget.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-releng/fxci-config] Bug 2048352 - Grant nhadji access to secret needed for reviewbot migr… (#1063)

Comment 3

[BMO Github Automation]

Authored by https://github.com/ahal
https://github.com/mozilla-releng/fxci-config/commit/d5356ee2fc195fe005754aac023c227800836fac
[main] Bug 2048352 - Grant nhadji access to secret needed for reviewbot migration testing

Comment 4

[Julien Cristau [:jcristau]]

Not quite resolved.