Closed Bug 2048435 Opened 5 months ago Closed 4 months ago

Remove the Quick Settings Dialog Fragment

Categories

(Firefox for Android :: Settings, task, P3)

All
Android
task

Tracking

()

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: gl, Assigned: gl)

References

Details

(Whiteboard: [fxdroid] [group5])

Attachments

(6 external files, 1 obsolete file)

Now that Unified Trust Panel has been enabled by default, we should clean up the old existing Quick Settings Dialog code and settings.enableUnifiedTrustPanel.

Assignee: nobody → gl
Status: NEW → ASSIGNED
Whiteboard: [fxdroid] [group5]
  • AutoplayValue and TrackingProtectionCategory will still be needed after removing old quick settings classes. Extract it from their existing classes.

Delete the layouts, drawables, styles, dimension, and strings that were only
used by the removed Quick Settings sheet and Enhanced Tracking Protection
panel, remove the now-unused SwitchWithDescription view and its styleable, and
prune the detekt and lint baselines of entries referencing the deleted files.

Resources still referenced by the unified trust panel and the site permissions
screens (the cookie banner UI mode strings, autoplay option strings, and
tracking protection category strings) are retained.

Attachment #9599103 - Attachment description: WIP: Bug 2048435 - Part 6: Remove resources orphaned by the legacy panel removal → WIP: Bug 2048435 - Part 6: Remove resources that were used by Quick Settings sheet and ETP panel
Attachment #9599098 - Attachment description: WIP: Bug 2048435 - Part 1: Extract AutoplayValue and TrackingProtectionCategory into their own file → WIP: Bug 2048435 - Part 1: Extract AutoplayValue, TrackingProtectionCategory, and CookieBannerUIMode into their own file
Attachment #9599101 - Attachment description: WIP: Bug 2048435 - Part 4: Remove the Enhanced Tracking Protection panel → WIP: Bug 2048435 - Part 3: Remove the Enhanced Tracking Protection panel
Attachment #9599102 - Attachment description: WIP: Bug 2048435 - Part 5: Remove the Quick Settings sheet → WIP: Bug 2048435 - Part 4: Remove the Quick Settings sheet
Attachment #9599103 - Attachment description: WIP: Bug 2048435 - Part 6: Remove resources that were used by Quick Settings sheet and ETP panel → WIP: Bug 2048435 - Part 5: Remove resources that were used by Quick Settings sheet and ETP panel
Attachment #9602456 - Attachment description: WIP: Bug 2048435 - Part 7: Remove UI tests for Quick Settings sheet and ETP Panel → WIP: Bug 2048435 - Part 6: Remove UI tests for Quick Settings sheet and ETP Panel
Attachment #9599100 - Attachment is obsolete: true
Blocks: 2053329
Attachment #9599098 - Attachment description: WIP: Bug 2048435 - Part 1: Extract AutoplayValue, TrackingProtectionCategory, and CookieBannerUIMode into their own file → Bug 2048435 - Part 1: Extract AutoplayValue, TrackingProtectionCategory, and CookieBannerUIMode into their own file
Attachment #9599099 - Attachment description: WIP: Bug 2048435 - Part 2: Remove the enableUnifiedTrustPanel settings → Bug 2048435 - Part 2: Remove the enableUnifiedTrustPanel settings
Attachment #9599101 - Attachment description: WIP: Bug 2048435 - Part 3: Remove the Enhanced Tracking Protection panel → Bug 2048435 - Part 3: Remove the Enhanced Tracking Protection panel
Attachment #9599102 - Attachment description: WIP: Bug 2048435 - Part 4: Remove the Quick Settings sheet → Bug 2048435 - Part 4: Remove the Quick Settings sheet
Attachment #9599103 - Attachment description: WIP: Bug 2048435 - Part 5: Remove resources that were used by Quick Settings sheet and ETP panel → Bug 2048435 - Part 5: Remove resources that were used by Quick Settings sheet and ETP panel
Attachment #9602456 - Attachment description: WIP: Bug 2048435 - Part 6: Remove UI tests for Quick Settings sheet and ETP Panel → Bug 2048435 - Part 6: Remove UI tests for Quick Settings sheet and ETP Panel
Pushed by gluong@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/4e4016d82bbe https://hg.mozilla.org/integration/autoland/rev/7219628d78ed Part 1: Extract AutoplayValue, TrackingProtectionCategory, and CookieBannerUIMode into their own file r=android-reviewers,petru https://github.com/mozilla-firefox/firefox/commit/a2e690ffbe79 https://hg.mozilla.org/integration/autoland/rev/3f8cfbd76025 Part 2: Remove the enableUnifiedTrustPanel settings r=android-reviewers,petru https://github.com/mozilla-firefox/firefox/commit/23df5aff5ef4 https://hg.mozilla.org/integration/autoland/rev/6719f22abe66 Part 3: Remove the Enhanced Tracking Protection panel r=android-reviewers,petru https://github.com/mozilla-firefox/firefox/commit/89c372eb782f https://hg.mozilla.org/integration/autoland/rev/6ecfd3362d25 Part 4: Remove the Quick Settings sheet r=android-reviewers,petru https://github.com/mozilla-firefox/firefox/commit/02b094cf9e7d https://hg.mozilla.org/integration/autoland/rev/5e63fcb8fc42 Part 5: Remove resources that were used by Quick Settings sheet and ETP panel r=android-reviewers,android-l10n-reviewers,petru,parker https://github.com/mozilla-firefox/firefox/commit/972b6926b117 https://hg.mozilla.org/integration/autoland/rev/d8bc299a6271 Part 6: Remove UI tests for Quick Settings sheet and ETP Panel r=android-reviewers,petru
Blocks: 2053618
See Also: → 2094991
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: